With entity cache enabled, I am not able to view node revisions. The following warnings show up in watchdog:

Warning: array_filter() expects parameter 1 to be array, string given in EntityCacheControllerHelper::entityCacheCleanIds() (line 215 of \sites\all\modules\entitycache\includes\entitycache.entitycachecontrollerhelper.inc).

Warning: array_map(): Argument #2 should be an array in EntityCacheControllerHelper::entityCacheCleanIds() (line 216 of \sites\all\modules\entitycache\includes\entitycache.entitycachecontrollerhelper.inc).

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jordanrussellsmith created an issue. See original summary.

jordanrussellsmith’s picture

Status: Needs review » Needs work

The last submitted patch, 2: clean-revision-id-2816171-2.patch, failed testing.

jordanrussellsmith’s picture

Status: Needs work » Needs review
FileSize
1.26 KB

Fixed the path in the patch. Forgot the --relative flag.

jordanrussellsmith’s picture

Status: Needs review » Reviewed & tested by the community

This patch is running on our live site and fixes the issue. Can we get this committed?

Chris Charlton’s picture

Super minor whitespace issue in the patch, otherwise it applies without issue.

greggles’s picture

Here's a reroll just to fix the tabs problem. Leaving at RTBC since it should be the same content. I didn't review myself.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 7: clean-revision-id-2816171-7.patch, failed testing. View results

Chris Charlton’s picture

Bot marked this as 'Needs Work' but it was RTBC. What does this need?

greggles’s picture

Status: Needs work » Needs review

The bot was broken for a bit. I think it's better now, so moving back to needs review to confirm it passes tests and then it can be moved back to RTBC.