On the translation tab, there is no way to tell if the actual node itself is published or unpublished. This can be confusing if translations are published but are not showing up (because the actual node itself might not be published).

For more information, please refer to this issue on Github.

Patch should add a "Node status:" element before the translation table that indicates whether the node itself is or published or not. Options for the value in that slot are "Published" or "Unpublished."

Patch for this update included in file.

CommentFileSizeAuthor
#12 reroll-2702055-11049231.patch5.39 KBchloealee
#4 entity_translation-adds_node_status_changes_to_unpublished_and_adds_translation_status_to_header-2702055-3-7.43.patch2.89 KBchloealee
#2 entity_translation-adds_node_status_and_changes_translation_status_to_published_unpublished_or_not_translated-2702055-1-7.43.patch2.74 KBchloealee
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

chloealee created an issue. See original summary.

chloealee’s picture

chloealee CreditAttribution: chloealee commented
Issue summary: View changes
FileSize
entity_translation-adds_node_status_and_changes_translation_status_to_published_unpublished_or_not_translated-2702055-1-7.43.patch2.74 KB
chloealee’s picture

chloealee CreditAttribution: chloealee commented
Status: Active » Needs review
chloealee’s picture

chloealee CreditAttribution: chloealee commented
FileSize
entity_translation-adds_node_status_changes_to_unpublished_and_adds_translation_status_to_header-2702055-3-7.43.patch2.89 KB

Here's an updated patch that also changes the header from "Status" to "Translation Status" so it's more explicit.

chloealee’s picture

chloealee CreditAttribution: chloealee commented

Here is a link to the patch: https://www.drupal.org/files/issues/entity_translation-adds_node_status_...

chloealee’s picture

chloealee CreditAttribution: chloealee commented
Issue summary: View changes
chloealee’s picture

chloealee CreditAttribution: chloealee commented
Issue summary: View changes
stefanos.petrakis@gmail.com’s picture

stefanos.petrakis@gmail.com
Primary language English
Location Biel, Switzerland
CreditAttribution: stefanos.petrakis@gmail.com as a volunteer commented

Could you, since this is about UX changes, update the issue's description with some screenshots to better explain what the requested change is about (like before/after)?

Status: Needs review » Needs work

The last submitted patch, 4: entity_translation-adds_node_status_changes_to_unpublished_and_adds_translation_status_to_header-2702055-3-7.43.patch, failed testing. View results

stefanos.petrakis@gmail.com’s picture

stefanos.petrakis@gmail.com
Primary language English
Location Biel, Switzerland
CreditAttribution: stefanos.petrakis@gmail.com as a volunteer commented

Hi again,

Here are two points to work on:
a) I found this => https://github.com/DoSomething/phoenix/issues/5876 which seems to be the same issue. If I am right, please add that link in the OP since it's quite informative.
b) The patch needs to be rerolled against the latest dev, it doesn't apply any more.

Thanks!

chloealee’s picture

chloealee CreditAttribution: chloealee commented
Issue summary: View changes
chloealee’s picture

chloealee CreditAttribution: chloealee commented
FileSize
reroll-2702055-11049231.patch5.39 KB

Thank you for your comments and advice, Stefanos!

Yes, you're right! That is the issue that was created to inform this patch. I have included it in the description as you suggest.

In addition, here is the re-rolled patch (attached). In this re-roll, I resolved the merge conflicts in entity_translation.admin.inc in order to apply the patch cleanly.

chloealee’s picture

chloealee CreditAttribution: chloealee commented
Status: Needs work » Needs review
plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach as a volunteer commented
Status: Needs review » Needs work
Issue tags: +Needs screenshots

This needs to work with any entity type, not just nodes, and not every entity type has a status property. So this indeed may make sense for nodes but make no sense for terms (for example). Hence we need to retrieve this information from the translation handler so that nodes (and any other entity type exposing the published concept, e.g. comments) can use it. We already have a protected method on the TH: EntityTranslationDefaultHandler::getStatus(), we can make that public and use it to determine he entity status in a generic way.

Also the patch is looking weird and does not seems to follow Drupal's coding standards.

As @stefanos.petrakis mentioned a before/after pair of screenshots would be appreciated.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach as a volunteer commented

Actually these UI additions would make no sense for non-publisheable entity types, so we would probably need a method to the TH to provide a render array to be merged into the translation overview's one.