Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
After making direct database updates to nodes, the nodes in question are not flushed from the entity load cache.
I noticed this whilst looking for instances of this problem in general in our code base, but as I'm not actually using entity_translation_upgrade, I haven't tested my patch, or tried to establish whether this is mitigated by other circumstances. (If it is, there should probably be at least a comment to that effect alongside the database update.)
Comment | File | Size | Author |
---|---|---|---|
#1 | entity_translation_upgrade-flush_entity_load_cache-1970246.patch | 1.72 KB | jweowu |
Comments
Comment #1
jweowu CreditAttribution: jweowu commentedComment #1.0
jweowu CreditAttribution: jweowu commentedUpdated issue summary.
Comment #3
jweowu CreditAttribution: jweowu commentedThe testbot failed to checkout the drupal repository. I've just seen this happen on multiple patch submissions, so I'll leave it alone for now, and try a re-test later.
Comment #4
plachThe patch looks good, but why is the second change needed? It looks unrelated to the cache issue.
Comment #5
jweowu CreditAttribution: jweowu commentedBoth the changes in that patch are flushing specific entities from the load cache after they have been modified directly in the database. Keeping my original caveats in mind, they looked to me like (separate) instances of the same bug.
Comment #6
plachAh, right, I missed the second flush :)
Comment #7
plachCommitted and pushed, thanks!
Comment #8.0
(not verified) CreditAttribution: commentedUpdated issue summary.