I started to write the release notes for beta1 and I realized the new permissions really need a new documentation section at least. Meanwhile @Berdir started a discussion about those in the D8 issue that continued in #1807776: Support both simple and editorial workflows for translating entities.

There is a proposal over there to make those permissions optional. I think having to explictly opt-in is a good idea: this would avoid many configuration/UX troubles for simple scenarios.

Obviously we want this in before beta1.

CommentFileSizeAuthor
#8 et-workflow_perms-1828794-7.interdiff.do_not_test.patch1.46 KBplach
#8 et-workflow_perms-1828794-7.patch9.42 KBplach
#5 et-workflow_perms-1828794-5.interdiff.do_not_test.patch502 bytesplach
#5 et-workflow_perms-1828794-5.patch9.43 KBplach
#1 et-workflow_perms-1828794-1.patch8.94 KBplach
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach commented
Status: Active » Needs review
FileSize
et-workflow_perms-1828794-1.patch8.94 KB

Here is a patch. I'd like to commit it in 8/10h and create beta1 soon afterwards.

Status: Needs review » Needs work

The last submitted patch, et-workflow_perms-1828794-1.patch, failed testing.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach commented
Status: Needs work » Needs review

#1: et-workflow_perms-1828794-1.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, et-workflow_perms-1828794-1.patch, failed testing.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach commented
Status: Needs work » Needs review
FileSize
et-workflow_perms-1828794-5.patch9.43 KB
et-workflow_perms-1828794-5.interdiff.do_not_test.patch502 bytes

Fixed tests and a @todo :)

bforchhammer’s picture

bforchhammer CreditAttribution: bforchhammer commented
Status: Needs review » Needs work

Very good changes, makes a lot of sense :)

+++ b/entity_translation.admin.inc
@@ -25,6 +25,15 @@ function entity_translation_admin_form($form, $form_state) {
+    '#description' => t('By enabling the translation workflow permissions it will be possible to limit the access to the entity form elements.
+      Once this is active every role previously allowed to access the entity form will need to be granted the <em>Edit original values</em> permission to edit the entity in the original language.
+      Moreover form elements dealing with values shared accross the translations will be visible only to roles having been granted the <em>Edit shared values</em> permission.'),

IMO this should be on one line; and there's a comma missing after "Moreover". :)

+++ b/entity_translation.install
@@ -249,3 +249,10 @@ function entity_translation_update_7003() {
+  variable_set('entity_translation_workflow_enabled', TRUE);

Shouldn't this be disabled? (Who is the update function targeted at? Alpha2 users or current DEV users?)

bforchhammer’s picture

bforchhammer CreditAttribution: bforchhammer commented

Hm, and while testing this I stumbled on: #1829630: Improve workflow permissions (match D8 solution)

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach commented
Status: Needs work » Needs review
FileSize
et-workflow_perms-1828794-7.patch9.42 KB
et-workflow_perms-1828794-7.interdiff.do_not_test.patch1.46 KB

(Who is the update function targeted at? Alpha2 users or current DEV users?)

People on alpha-2 are used to have translations forms, while people on dev have the workflow permissions in place so both need this enabled.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach commented
Status: Needs review » Fixed

This addresses #6, hence committed and pushed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) CreditAttribution: commented
Issue summary: View changes

Updated issue summary.

  • Commit fc1defc on 7.x-1.x, et-permissions-1829630, factory, et-fc, revisions by plach: 
    Issue #1828794 by plach: Make translation workflow permissions optional.

  • Commit fc1defc on 7.x-1.x, et-permissions-1829630, factory, et-fc, revisions, workbench by plach: 
    Issue #1828794 by plach: Make translation workflow permissions optional.