Spun-off from #1798456-3: Hide shared form elements when the user has not the related permission:

I think the bundle/id properties should actually be set by the setEntity() method to make sure they always match the wrapped entity... as far as I can see, this also means that we can remove the $entity_id constructor argument.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

plach’s picture

Status: Active » Fixed

Committed and pushed, thanks.

bforchhammer’s picture

Status: Fixed » Postponed
FileSize
829 bytes

3rd party entity translation handlers need to remove the $entity_id argument from constructor calls. I have updated the media patch (#1470018-17: Provide Entity Translation integration) and added an issue for the bean module: #1799776: Fix entity translation regressions.

Any other handlers that need updating?

Afterwards, attached patch should go in as a cleanup...

plach’s picture

I just updated #1495570: Update Entity translation integration.
(You'd be welcome to review/test it ;)

bforchhammer’s picture

Status: Postponed » Reviewed & tested by the community

I'm not aware of any ET handlers that still need updating, so I think this can be committed now.

plach’s picture

I'd prefer to wait after beta1.

plach’s picture

Status: Reviewed & tested by the community » Postponed

I though about this. I guess it would be better to give time to catch-up with the new API until 1.0 is released.

  • Commit b02d8a1 on 7.x-1.x, et-permissions-1829630, factory, et-fc, revisions authored by bforchhammer, committed by plach:
    Issue #1799770 by bforchhammer: Updated id and bundle when setting a...

  • Commit b02d8a1 on 7.x-1.x, et-permissions-1829630, factory, et-fc, revisions, workbench authored by bforchhammer, committed by plach:
    Issue #1799770 by bforchhammer: Updated id and bundle when setting a...
ciss’s picture

Issue summary: View changes
Status: Postponed » Fixed

I'm guessing that this issue can be considered fixed, as the @todo comment got removed in the commit for #1865244: Allow multiple translation handlers on the same form.

plach’s picture

ciss’s picture

My bad, missed that. Sorry. :)

plach’s picture

plach’s picture

Status: Postponed » Needs review
FileSize
1.93 KB

Updated patch.

  • plach committed 87580d1 on 7.x-1.x
    Issue #1799770 by plach, bforchhammer: Update id and bundle when setting...
plach’s picture

Status: Needs review » Fixed

Committed and pushed.

plach’s picture

Issue tags: +API change

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.