Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Spun-off from #1798456-3: Hide shared form elements when the user has not the related permission:
I think the bundle/id properties should actually be set by the
setEntity()
method to make sure they always match the wrapped entity... as far as I can see, this also means that we can remove the$entity_id
constructor argument.
Comment | File | Size | Author |
---|---|---|---|
#13 | et-rm_deprecated-1799770-13.patch | 1.93 KB | plach |
| |||
#2 | et-entity_id-cleanup-2.patch | 829 bytes | bforchhammer |
Comments
Comment #1
plachCommitted and pushed, thanks.
Comment #2
bforchhammer CreditAttribution: bforchhammer commented3rd party entity translation handlers need to remove the
$entity_id
argument from constructor calls. I have updated the media patch (#1470018-17: Provide Entity Translation integration) and added an issue for the bean module: #1799776: Fix entity translation regressions.Any other handlers that need updating?
Afterwards, attached patch should go in as a cleanup...
Comment #3
plachI just updated #1495570: Update Entity translation integration.
(You'd be welcome to review/test it ;)
Comment #4
bforchhammer CreditAttribution: bforchhammer commentedI'm not aware of any ET handlers that still need updating, so I think this can be committed now.
Comment #5
plachI'd prefer to wait after beta1.
Comment #6
plachI though about this. I guess it would be better to give time to catch-up with the new API until 1.0 is released.
Comment #9
ciss CreditAttribution: ciss commentedI'm guessing that this issue can be considered fixed, as the @todo comment got removed in the commit for #1865244: Allow multiple translation handlers on the same form.
Comment #10
plachIt can't :)
http://cgit.drupalcode.org/entity_translation/tree/includes/translation....
Comment #11
ciss CreditAttribution: ciss commentedMy bad, missed that. Sorry. :)
Comment #12
plachComment #13
plachUpdated patch.
Comment #15
plachCommitted and pushed.
Comment #16
plach