Problem/Motivation

There is a special case on the EntityFormatter of the module that is not needed.

Proposed resolution

Remove it.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#4 interdiff-2704717-2-4.txt1.03 KBjohnchque
#4 remove_special_case_on-2704717-4.patch1.88 KBjohnchque
#2 remove_special_case_on-2704717-2.patch1.81 KBjohnchque

Comments

yongt9412 created an issue. See original summary.

johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
commented
Status: Active » Needs review
StatusFileSize
new remove_special_case_on-2704717-2.patch1.81 KB

Should be fine. :)

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Title: Remove special case on EntityFormatter » Remove special case on EntityFormatter for new entities.
Status: Needs review » Reviewed & tested by the community

Not sure about test coverage. We certaionly add tests in paragraphs.

johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new remove_special_case_on-2704717-4.patch1.88 KB
new interdiff-2704717-2-4.txt1.03 KB

Discussed. This approach should work.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Reviewed & tested by the community

Yes, this should be save.

As discussed, lets try to do this in core too, with the same changes.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

For the core issue, we might also want to update the entity_view() call with an injected entity view builder, we can do that in a follow-up too in ERR but shouldn't block the release on it.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Reviewed & tested by the community » Fixed

Committed, thx.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.