Problem/Motivation

In PHP 8.4 implicit nullables are deprecated.

CommentFileSizeAuthor
#8 entity_print-3497095.patch3.05 KBklausi

Issue fork entity_print-3497095

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

acbramley created an issue. See original summary.

acbramley opened merge request !68

acbramley’s picture

acbramley commented
Status: Active » Needs review
Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Reviewed & tested by the community

Hi @acbramley
I reviewed your MR and all the implicit nullables deprecation errors have been fixed.
There seem to be some more pipeline errors which are being fixed in #3352346.
This MR can be merged.
Moving to RTBC+

solideogloria’s picture

solideogloria commented
Issue tags: +PHP 8.4
liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

Looks good

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Reviewed & tested by the community » Needs work

Thanks, I think the merge request should only change the nullable types compatibility, but I also see use statement changes? Is that on purpose?

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
StatusFileSize
new entity_print-3497095.patch3.05 KB

Attaching stable patch file for composer patches without the use statements in the meantime.

acbramley’s picture

acbramley commented
Status: Needs work » Reviewed & tested by the community

Reverted

jsacksick made their first commit to this issue’s fork.

  • jsacksick committed 6576bbd6 on 8.x-2.x authored by acbramley 
    Issue #3497095 by acbramley, klausi, akulsaxena, solideogloria, liam...
jsacksick’s picture

jsacksick commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.