Problem/Motivation

The entity_print_views submodule isn't print results of a view w.r.t to pager instead of printing only the results displaying on the first page. even the pager is also not in sync.

Steps to reproduce

  1. Create a view that produces more than one result (say, 5 results.)
  2. Configure the view to use a pager displaying fewer rows than the total results from Step 1 above (say, 5 results)
  3. Add the Global 'Print' area to the header or footer
  4. Render the view, click on the 'View PDF' link and observe that the when you click on pager 2 or 3 (so on) always print the content of page 1 , content not change w.r.t to page

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#4 Afterpatch_Test _ D10 (1).mp41.7 MBkanchan bhogade
#4 Test _ D10_issue.mp41.3 MBkanchan bhogade
#3 After_adding_patch.gif1.15 MBpooja_sharma
print_view_not_work_per_pager.gif1.2 MBpooja_sharma

Issue fork entity_print-3424654

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

pooja_sharma created an issue. See original summary.

pooja_sharma opened merge request !53

pooja_sharma’s picture

pooja_sharma commented
Assigned: pooja_sharma » Unassigned
Status: Active » Needs review
StatusFileSize
new After_adding_patch.gif1.15 MB
kanchan bhogade’s picture

kanchan bhogade commented
StatusFileSize
new Test _ D10_issue.mp41.3 MB
new Afterpatch_Test _ D10 (1).mp41.7 MB

Hi
I've tested MR !53 on Drupal version 10
The patch applied successfully...

Testing Steps:

  1. Install Drupal version
  2. Install "Entity Print" module
  3. Create content for any content type like an Article (add 5-6 nodes)
  4. Create a view for content type and add a pager with 2or3 items.
  5. Add "Global: print" in the Footer/Header of view display.
  6. Go to the view, click on the 'View PDF' link, and observe that when you click on page 2 or 3 (and so on) always print the content of page 1, content does not change w.r.t to page
  7. Apply patch check for the same

Test Result:
Now if click on the 'View PDF' link of any page, can print the content w.r.t. particular page like if click on 2nd page "View PDF" print the 2nd page content

Added videos for reference

Keeping in need review for the code verification

carolpettirossi’s picture

carolpettirossi commented
Status: Needs review » Reviewed & tested by the community

I applied the MR and it worked perfectly on my case. Moving this to RTBC. Hopefully this can be pushed to the next release.

tame4tex’s picture

tame4tex commented
Status: Reviewed & tested by the community » Needs work

Added a comment to the MR as I don't think we should be adding an empty page parameter if we don't need to.

pooja_sharma’s picture

pooja_sharma commented
Status: Needs work » Needs review

Thanks for suggestion, I have addressed the requested change - no need to add page parameter if empty

Please review , moving NR.

tame4tex’s picture

tame4tex commented
Status: Needs review » Reviewed & tested by the community

The MR looks good to me and is working well across a number of our sites. Thanks!

vladimiraus made their first commit to this issue’s fork.

jannakha made their first commit to this issue’s fork.

jannakha’s picture

jannakha commented
Status: Reviewed & tested by the community » Fixed

merged

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.