Problem/Motivation

It is often useful to only send notifications for specific bundles.

Proposed resolution

Add bundle support

Remaining tasks

User interface changes

Add a bundle selection checkbox in the UI. If ticked, list the available bundles. If bundles are selected only send mails for entities matching these.

API changes

Pass entity bundle info service into settings form.

Data model changes

New bundles key in configuration. However the code is such that an upgrade path is not required.

CommentFileSizeAuthor
#6 3-4-interdiff.txt599 bytesalexpott
#6 2803743.4.patch10.38 KBalexpott
#3 2803743.3.patch10.37 KBalexpott
#3 2-3-interdiff.txt504 bytesalexpott
#2 2803743.2.patch10.67 KBalexpott
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Active » Needs review
FileSize
2803743.2.patch10.67 KB

Here it is...

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
FileSize
2-3-interdiff.txt504 bytes
2803743.3.patch10.37 KB

Removing an unnecessary change...

Status: Needs review » Needs work

The last submitted patch, 3: 2803743.3.patch, failed testing.

The last submitted patch, 2: 2803743.2.patch, failed testing.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Needs work » Needs review
FileSize
2803743.4.patch10.38 KB
3-4-interdiff.txt599 bytes

Whoops.

Status: Needs review » Needs work

The last submitted patch, 6: 2803743.4.patch, failed testing.

milos.kroulik’s picture

milos.kroulik CreditAttribution: milos.kroulik commented

This seems to be working fine for me. Is this sufficient for RTBC?

milos.kroulik’s picture

milos.kroulik CreditAttribution: milos.kroulik commented

Useful follow up would be ability to set up different behaviours based on bundle.

LpSolit’s picture

LpSolit CreditAttribution: LpSolit as a volunteer commented

Shouldn't each bundle have its own section (tab)? This way, one could send notifications to different users (and using different mail content) based on the bundle.

kyberman’s picture

kyberman
Location Czech Rep. 🇨🇿
CreditAttribution: kyberman at Morpht commented

Thank you, patch #6 is working correctly with current dev.

As @milos.kroulik and @LpSolit are saying, it would be better to split settings by bundles, so we can set different notification for different bundles.

I can imagine the same structure as we have here: "/admin/structure/types/manage/article/display".
- one main tab for every entity type
- one secondary tab for every bundle
- one vertical tab for every CRUD event