ReorderChildrenAccess results in uncacheable pages [#3285735]

Problem/Motivation

It seems that AccessResult returned by ReorderChildrenAccess is making the block non cachable as max-age is set to 0
This is breaking dynamic cache.
I think it would be good to add have catchable meta

Steps to reproduce

Visit any node page which has local task block enabled.
For authenticated users dynamic-drupal-cache always becomes UNCACHEABLE

Proposed resolution

Add cachability metadata

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork entity_hierarchy-3285735

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3285735-5.x changes, plain diff MR !68
Check out this branch for the first time

Check out existing branch, if you already have it locally
3285735-adding-cachable-metadata changes, plain diff MR !11
Check out this branch for the first time

Check out existing branch, if you already have it locally

1 hidden branch

5.x

compare

Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

15 June 2022 at 03:19

mohit_aghera created an issue. See original summary.

Comment #2

mohit_aghera commented 15 June 2022 at 03:32

Assigned:	Unassigned	» mohit_aghera
Status:	Active	» Needs work

Comment #3

15 June 2022 at 03:52

mohit_aghera opened merge request !11

Comment #4

larowlan

🇦🇺🏝.au GMT+10

commented 15 June 2022 at 04:24

Anyway we can add a test for this?
And if so, would be keen to see if user.permissions works instead of user

Comment #5

mohit_aghera commented 15 June 2022 at 11:50

Assigned:	mohit_aghera	» Unassigned
Status:	Needs work	» Closed (cannot reproduce)

After digging through the cacheable metadata, I came across that issue was not related to this module.
I think we can close this issue.

I tested one test-only patch and it was working fine.

Comment #6

acbramley commented 3 September 2024 at 23:38

Title:	Adding cachable metadata on ReorderChildrenAccess results	» ReorderChildrenAccess results in uncacheable pages
Category:	Task	» Bug report
Status:	Closed (cannot reproduce)	» Active