Closed (fixed)
Project:
Entity Reference Hierarchy
Version:
8.x-2.x-dev
Component:
Code (module)
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
23 Feb 2021 at 10:18 UTC
Updated:
4 Dec 2021 at 16:48 UTC
Jump to comment: Most recent, Most recent file


Comments
Comment #2
simeComment #3
simeComment #4
simeComment #5
simeTests and linting included.
Comment #7
simeComment #8
simeLinting
Comment #9
simeComment #10
simeJust looking at isolated query performance of the Root relationship i get 250ms in prod for 50 records. This being the query for the /admin/content view, plus the root relationship.
If i up this too much, or add a sort on say
eh_for_node_field_data.nid, which I think will need to query the whole result first to then apply the sort and limit, then it starts to slow down. I'm not sure what this should scale too.Comment #11
simeThere's a cross join in the root relationship.
Comment #12
simeCorrection, it's missing the vid/revision in the WHERE. That explains the slowness...
Comment #13
simeFixes the join to include revision key if appropriate.
+ if ($revision_key = $entity_type->getKey('revision_id')) {+ if ($revision_key = $entity_type->getKey('revision')) {Comment #14
sime1000 rows on this site is more performant now.
Comment #15
simeComment #16
simeComment #17
larowlanThese are looking great, thanks sime
Comment #18
larowlanHere's some tests for revisionable entity-types.
I think this should be a follow-up issue:
Comment #20
larowlanCrediting Vj from #3125684: Views relationships for parent is not automatically detected
Comment #21
larowlanCombined patch with #3125684: Views relationships for parent is not automatically detected
Comment #23
larowlanRe-roll on top of #3200880: HEAD broken on 9.x
Comment #24
larowlanThis will be 3.0.0-rc1
Let's get some eyes on it
Comment #26
delacosta456 commentedhi
It'z looks like the is a bug related to relation ship.
When settings up the relationship without enabling "require this relationship", when on view preview and logged in as admin everything display as expected for administrator
But when logging with another user with different role that has necessary permission the view behave like if "require this relationship" was enabled