Process callback deselects any selection checkboxes that might be active at rebuild (after validation fail, after filters submit, ...). It is sometimes not called due to the slightly wrong condition.

CommentFileSizeAuthor
#7 interdiff-2-7.txt729 bytesmarcoscano
#7 2932081-7.patch2.8 KBmarcoscano
#2 2932081_2.patch2.78 KBslashrsm
#2 2932081_2_TEST_ONLY.patch1.46 KBslashrsm
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

slashrsm created an issue. See original summary.

slashrsm’s picture

slashrsm CreditAttribution: slashrsm at MD Systems GmbH commented
Status: Active » Needs review
FileSize
2932081_2_TEST_ONLY.patch1.46 KB
2932081_2.patch2.78 KB

The last submitted patch, 2: 2932081_2_TEST_ONLY.patch, failed testing. View results

marcoscano’s picture

marcoscano
Primary language Portuguese, Brazil
Location Barcelona, Spain
CreditAttribution: marcoscano at MD Systems GmbH commented
Status: Needs review » Reviewed & tested by the community

Works for me as expected, marking as RTBC

Primsi’s picture

Primsi CreditAttribution: Primsi at MD Systems GmbH for MD Systems GmbH commented 
+++ b/src/Plugin/EntityBrowser/Widget/View.php
@@ -136,7 +136,7 @@ class View extends WidgetBase implements ContainerFactoryPluginInterface {
     // When rebuilding makes no sense to keep checkboxes that were previously
     // selected.

Should then this comment be moved too?

samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
CreditAttribution: samuel.mortenson at Acquia commented
Issue tags: +Nashville2018, +D8Media
marcoscano’s picture

marcoscano
Primary language Portuguese, Brazil
Location Barcelona, Spain
CreditAttribution: marcoscano as a volunteer commented
FileSize
2932081-7.patch2.8 KB
interdiff-2-7.txt729 bytes

No real change here, only removed the comment mentioned in #5 and triggering the tests again for both branches.

mpp’s picture

mpp CreditAttribution: mpp at AmeXio for District09 commented

Successfully tested the patch in #7. RTBC so can be committed.

  • slashrsm committed 553d31f on 8.x-2.x 
    Issue #2932081 by slashrsm, marcoscano, Primsi: \Drupal\entity_browser\...
slashrsm’s picture

slashrsm CreditAttribution: slashrsm commented
Status: Reviewed & tested by the community » Fixed

Committed. Thanks!

  • slashrsm committed 103dbc1 on 8.x-1.x 
    Issue #2932081 by slashrsm, marcoscano, Primsi: \Drupal\entity_browser\...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.