Problem/Motivation

Since yesterday the tests of the crop widget image module no longer seems to pass correctly in 8.5 on the example module having a dependency with Entity Browser and Ctools cause by the use of deprecated interface. Here is the patch to convert to the new format.

Proposed resolution

Convert all RouteEnhancerInterface usage with new one and implement a new method to evaluate of condition are satisfated to arround complexity problem of methods (extract method).

@see https://www.drupal.org/node/2894934

Remaining tasks

User interface changes

API changes

Data model changes

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

woprrr created an issue. See original summary.

woprrr’s picture

Status: Active » Needs review
FileSize
1.95 KB

That patch is applicable for 1.x and 2.x

Status: Needs review » Needs work

The last submitted patch, 2: convert_deprecated-8.2-x-2922303-2.patch, failed testing. View results

woprrr’s picture

Status: Needs work » Needs review

This Patch works well but fail because other tests fail.

Berdir’s picture

Status: Needs review » Needs work

Makes sense, but we should probably add a "drupal:system (>=8.5) dependency?

I think the deprecated messages were probably caused by something else, should no longer happen like that for contrib.

oknate’s picture

Trying to figure out why the test about no entity browsers is failing in ConfigUITest. I added a test to check if there are no entity browsers at the beginning of the test, just to trying to figure out if that's why the test is failing. It seems like there aren't any entity browsers, but that test checking for "There is no Entity browser yet." is failing. Is this text changed in Drupal 8.6?

Ah Drupal 8.5:

'#empty' => $this->t('There is no @label yet.', ['@label' => $this->entityType->getLabel()]),

Drupal 8.6:

'#empty' => $this->t('There are no @label yet.', ['@label' => $this->entityType->getPluralLabel()]),

I created a separate issue to fix this:

https://www.drupal.org/project/entity_browser/issues/2966853

oknate’s picture

Status: Needs work » Closed (won't fix)

The current plan for entity browser is to drop the ctools dependency. See #2764875: Remove ctools dependency by building own admin UI.

When that's merged, CtoolsFallbackRouteEnhancer will be removed.