Problem/Motivation

When Drupal 10.2 will no more be supported, test if https://www.drupal.org/node/3436859 can reduce codebase and/or improve performance and/or just modernize the codebase.

Issue fork entity_access_password-3437555

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Grimreaper created an issue. See original summary.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: Unassigned » grimreaper
Status: Postponed » Active

Let's do that on 1.1.x

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Title: [After D10.2 EOL] Use tagged iterators » Use tagged iterators
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Version: 1.0.x-dev » 1.1.x-dev

Grimreaper opened merge request !15

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Status: Active » Needs work

Hum, when I execute PHPCS locally, I obtain:

FILE: project/app/modules/custom/entity_access_password/src/Plugin/Field/FieldType/EntityAccessPasswordItem.php
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
 1 | ERROR | An error occurred during processing; checking has been aborted. The error message was: Tags support is not enabled. Enable the "Yaml::PARSE_CUSTOM_TAGS" flag to use "!tagged_iterator" at line 13
   |       | (near "!tagged_iterator entity_access_password_password_validator").
   |       | The error originated in the DrupalPractice.Objects.GlobalDrupal sniff on line 102.
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

While it is ok on Drupal.org.

PHPCS config: https://gitlab.com/florenttorregrosa-drupal/docker-drupal-project/-/blob...

I tried to remove the yml extension from the list of scanned extension, I obtain the same result.

Edit:

I tried to compare versions with CI:

root@619b79f9dbef:/project# composer show | awk '$0 ~ /codesniffer|coder|coding-standard|variable-analysis/ {print $1 " " $2}';
clue/ndjson-react 1.3.0
dealerdirect/phpcodesniffer-composer-installer 1.0.0
drupal/coder 8.3.24
sirbrillig/phpcs-variable-analysis 2.11.18
slevomat/coding-standard 8.15.0
squizlabs/php_codesniffer 3.10.1

On https://git.drupalcode.org/project/entity_access_password/-/jobs/1948123:

 composer show | awk '$0 ~ /codesniffer|coder|coding-standard|variable-analysis/ {print $1 " " $2}';
dealerdirect/phpcodesniffer-composer-installer 1.0.0
drupal/coder 8.3.24
sirbrillig/phpcs-variable-analysis 2.11.18
slevomat/coding-standard 8.15.0
squizlabs/php_codesniffer 3.10.1
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: grimreaper » Unassigned
Status: Needs work » Fixed

  • Grimreaper committed 907f3c43 on 1.1.x 
    Issue #3437555 by Grimreaper: Use tagged iterators

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.