Problem/Motivation

\Drupal\encrypt_kms\Plugin\KeyProvider\AwsKmsKeyProvider::deleteKeyValue() does not pass the correct argument type to $this->secretStorage->delete()

Steps to reproduce

Try calling this method. I need to do it on a project where I'm setting the key from a source other than \Drupal\encrypt_kms\Plugin\KeyType\KmsDataKeyType::generateKeyValue()

Proposed resolution

Fix the code.

Remaining tasks

None

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#4 3482249-2.patch588 bytesalexpott

Issue fork encrypt_kms-3482249

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alexpott created an issue. See original summary.

alexpott opened merge request !2

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
StatusFileSize
new 3482249-2.patch588 bytes

A patch for composer patches.

krystalcode’s picture

krystalcode commented
Status: Needs review » Reviewed & tested by the community

Patch works.