Patch for problems found in code review

Hi,

CivicActions is reviewing and upgrading modules for use on client sites. Part of this process is an internationalization review. A number of internationalization issues were found, mainly to do with the following syntax:

$var = t('Download the module !link', array('!link' => l(t('here), 'http://drupal.org/project/emfield')));

This is invalid because it doesn't provide any context to the translator. Instead the following syntax should be used.

$var = t('Download the module <a href="@link">here</a>', array('@link' => 'http://drupal.org/project/emfield'));

There were a couple of other internationalization fixes too, including removal of leading/trailing spaces in strings passed to t() - this causes problems for the translators and often prevents some translations from appearing.

Finally, there are a few Drupal 5 to Drupal 6 api changes. In Drupal 6, (un)serialize() should not be used on cache_set() and cache_get() data - see http://drupal.org/node/114774#cache-data-parameter for more details.

Hope the patch helps.

Cheers,
Stella