What issues should be fixed before the 7.x-1.3 release of Email Change Confirmation?

I'll suggest:

* #2088291: More granular permission on email confirmation.
* #2478935: Undefined variable: default_form in email_confirm_build_mail()
* #2463481: Expirations can be bypassed and username enumeration
* #2811837: Email change should be case insensitive
* #2809045: Set old and new email addresses in params for both mails
* #2816161: Simpletests
* #2516686: Improve ability to translate email_confirm ("You currently have a pending change of your e-mail address") and mails
* #2818549: Update for Drupal code style

Comments

greggles created an issue. See original summary.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles at CARD.com commented
Issue summary: View changes
greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles at CARD.com commented
Issue summary: View changes
greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles at CARD.com commented
Issue summary: View changes
greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles at CARD.com commented
Issue summary: View changes
greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles at CARD.com commented

OK, everything is done except tests are still not passing on drupal.org.

They pass for me locally in a php5.5 + mysql5.5 environment, so I'm not really sure what would be different. The current errors are:

exception: [Notice] Line 101 of sites/all/modules/email_confirm/tests/email_confirm.test:
Undefined offset: 3

exception: [Notice] Line 104 of sites/all/modules/email_confirm/tests/email_confirm.test:
Undefined offset: 5

exception: [Notice] Line 107 of sites/all/modules/email_confirm/tests/email_confirm.test:
Undefined offset: 4

exception: [Notice] Line 110 of sites/all/modules/email_confirm/tests/email_confirm.test:
Undefined offset: 3

exception: [Notice] Line 141 of sites/all/modules/email_confirm/tests/email_confirm.test:
Undefined offset: 5

So it seems that something about the parse_url is not working. I'm going to try playing with that to get it working.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles at CARD.com commented

timplunkett helped me out: the test bot runs in a subdirectory, so of course the indexes are not right in that environment.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles at CARD.com commented
greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles at CARD.com commented

OK, all those things are fixed. Yay!

Normally I would wait a few days for folks to test things out. However, given there's a critical issue (#2088325) in the prior release, I'm going to make the release now. If any new bugs are found in the 7.x-1.3 release in the next few days there can always be another release.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles at CARD.com commented
Status: Active » Fixed

There it is https://www.drupal.org/project/email_confirm/releases/7.x-1.3

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.