The markup "You currently have a pending change of your email address to %email
" leaves a bit to be desired, since immediately after comes "A valid e-mail address. All e-mails from the system will be sent to this address." This doesn't really make sense to me.

CommentFileSizeAuthor
#1 clarify_email_change_message-2244011-1.patch1.3 KBjessehs
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jessehs’s picture

jessehs
he/him
Primary language English
Location Taos, New Mexico
CreditAttribution: jessehs commented
Status: Active » Needs review
FileSize
clarify_email_change_message-2244011-1.patch1.3 KB

This patch changes it to a div above the email field with the classes "messages warning" to give it the same appearance as a drupal message in most themes. This makes the message totally separate from the description of the email field.

Fabianx’s picture

Fabianx CreditAttribution: Fabianx commented
Status: Needs review » Reviewed & tested by the community

RTBC this looks great! Thanks so much!

jaydub’s picture

jaydub CreditAttribution: jaydub commented

Side note, in D8 looks like it's email vs e-mail. For this version of the module though I will use D7 standards which means e-mail.

https://www.drupal.org/style-guide/content#relatedwords

jaydub’s picture

jaydub CreditAttribution: jaydub commented
Status: Reviewed & tested by the community » Fixed

Thanks for the patch, committed with minor change in location of notice.

  • jaydub committed c4fc9c9 on 7.x-1.x 
    Issue #2244011 by jessehs, jaydub - Change location of warning about...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.