Problem/Motivation

The cacheBackend is set in __construct(), but never used.

Steps to reproduce

None.

Proposed resolution

Remove it.

Remaining tasks

User interface changes

None.

API changes

Remove the property setting in the class and services file.

Data model changes

None.

CommentFileSizeAuthor
#9 reroll.patch2.17 KBelber
#7 reroll-3340462.patch1.54 KBelber
#4 3346028-4.patch1.96 KBelber

Comments

PapaGrande created an issue. See original summary.

elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented

I will work on it.

elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented
Assigned: Unassigned » elber
elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented
Assigned: elber » Unassigned
Status: Active » Needs review
StatusFileSize
new 3346028-4.patch1.96 KB

Hi please revise.

papagrande’s picture

papagrande
Primary language English
commented
Status: Needs review » Needs work

@elber, #4 looks good, but needs a reroll against the 2.0.x branch after I committed your patch from https://www.drupal.org/project/eloqua_api_redux/issues/3340462.

elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented
Assigned: Unassigned » elber

I will do that.

elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented
Assigned: elber » Unassigned
Status: Needs work » Needs review
StatusFileSize
new reroll-3340462.patch1.54 KB

reroll added.

papagrande’s picture

papagrande
Primary language English
commented
Status: Needs review » Needs work 
+++ b/eloqua_api_redux.services.yml
@@ -1,7 +1,7 @@
+    arguments: ['@config.factory', '@logger.factory', '@http_client_factory']

@elber, thank you. #7 almost works, but this needs to be added as you had in patch #4..

elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented
Status: Needs work » Needs review
StatusFileSize
new reroll.patch2.17 KB

  • PapaGrande committed 31bf3db1 on 2.0.x 
    Issue #3346028: Make typehint more strict and clearer

  • PapaGrande committed b4e7d748 on 2.0.x authored by elber 
    Issue #3346028 by elber: Removed unused cacheBackend from...
papagrande’s picture

papagrande
Primary language English
commented
Status: Needs review » Fixed

Thanks a lot, @elber!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.