Remove the JS addition from eloqua_init() and move it to an ['#attached'] array element on a form via an alter.

CommentFileSizeAuthor
#5 interdiff.txt892 bytesAlbert Volkman
#5 2191223--5-visibility.patch6.93 KBAlbert Volkman
#2 2191223--2-visibility.patch6.92 KBdrupalninja99
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

drupalninja99’s picture

drupalninja99 CreditAttribution: drupalninja99 commented

I will add in some visibility settings like you see in other modules.

drupalninja99’s picture

drupalninja99 CreditAttribution: drupalninja99 commented
Status: Active » Needs review
FileSize
2191223--2-visibility.patch6.92 KB

I have a patch that looks like it works pretty good. I stole it from Pardot who stole it from google analytics.

Albert Volkman’s picture

Albert Volkman CreditAttribution: Albert Volkman commented

Wondering... since this javascript is only used in tandem with forms, would it be better to move it out of hook_init() and into a hook_form_alter()?

drupalninja99’s picture

drupalninja99 CreditAttribution: drupalninja99 commented

No Eloqua is used on every page for tracking. Thats why I added the visibility stuff so admins could have more control.

Albert Volkman’s picture

Albert Volkman CreditAttribution: Albert Volkman commented
FileSize
2191223--5-visibility.patch6.93 KB
interdiff.txt892 bytes

One small fix to the comments.

drupalninja99’s picture

drupalninja99 CreditAttribution: drupalninja99 commented
Status: Needs review » Fixed

Pushed to 7.x-1.x. The Drupal.org packager is having problems but I will try to put out a new release this week.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.