eloqua fieldset's field not showing [#2184739]

There is a bug in 7.x-1.11 on eloqua_webform.module line 69
if (!in_array($component_type, array('fieldset', 'pagebreak'))) {

the "!" should be deleted.

With "!" in this code, "Eloqua Field name" doesn't show up for "textfield" field type.

When I delete "!", it works as supposed to be.

Comment	File	Size	Author
#7	2184739--eloqua-webform-fix.patch	2.71 KB	drupalninja99
#4	2184739-fieldset-not-showing-4.patch	668 bytes	Albert Volkman
#1	respect_conditions-1126688-11.patch	4.36 KB	Albert Volkman

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Albert Volkman CreditAttribution: Albert Volkman commented 6 February 2014 at 20:10

Status:

Active

» Needs review

File	Size
respect_conditions-1126688-11.patch	4.36 KB

Yep, this looks like a bug. Here's a patch.

Comment #2

drupalninja99 CreditAttribution: drupalninja99 commented 6 February 2014 at 21:30

I am pretty confused by this. The issue you describe looks completely different than this patch. I don't know where this patch is coming from?

Comment #3

drupalninja99 CreditAttribution: drupalninja99 commented 6 February 2014 at 21:32

Also I will do some testing but "if (!in_array($component_type, array('fieldset', 'pagebreak'))) {" makes sense to me as is. That code is meant to skip fieldset and pagebreaks which are not compatible with values that would be sent to Eloqua.

Comment #4

Albert Volkman CreditAttribution: Albert Volkman commented 6 February 2014 at 21:57

File	Size
2184739-fieldset-not-showing-4.patch	668 bytes

1 file was hidden/shown/deleted

File	Size
respect_conditions-1126688-11.patch	4.36 KB

My apologies, uploaded the wrong patch.

So, have a look at this code-

http://drupalcode.org/project/eloqua.git/blob/refs/heads/7.x-1.x:/eloqua...

It's currently saying 'If the component is NOT a fieldset or pagebreak, add the markup "This component type is not compatible with the Eloqua Module." and return'. That's opposite of what we need, no?