Hi,
Are there any plans to introduce D8 version of this module?
I would like to help you with development of this version or to implement it from scratch.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

shkiper’s picture

Status: Active » Needs review
FileSize
11.29 KB

I've made a Drupal 8 version of this module. Could someone please review my patch?

a.sinitsa’s picture

Status: Needs review » Needs work

errors while installing

The website encountered an unexpected error. Please try again later.ReflectionException: Class \Drupal\ejectorseat\Controller\DefaultController does not exist in ReflectionMethod->__construct() (line 123 of core/lib/Drupal/Core/Entity/EntityResolverManager.php).

Drupal\Core\Entity\EntityResolverManager->setParametersFromReflection(Array, Object) (Line: 208)
Drupal\Core\Entity\EntityResolverManager->setRouteOptions(Object) (Line: 48)
Drupal\Core\EventSubscriber\EntityRouteAlterSubscriber->onRoutingRouteAlterSetType(Object, 'routing.route_alter', Object) (Line: 108)
Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch('routing.route_alter', Object) (Line: 184)
Drupal\Core\Routing\RouteBuilder->rebuild() (Line: 83)
Drupal\Core\ProxyClass\Routing\RouteBuilder->rebuild() (Line: 1141)
drupal_flush_all_caches() (Line: 174)
Drupal\system\Form\PerformanceForm->submitCacheClear(Array, Object)
call_user_func_array(Array, Array) (Line: 111)
Drupal\Core\Form\FormSubmitter->executeSubmitHandlers(Array, Object) (Line: 51)
Drupal\Core\Form\FormSubmitter->doSubmitForm(Array, Object) (Line: 585)
Drupal\Core\Form\FormBuilder->processForm('system_performance_settings', Array, Object) (Line: 314)
Drupal\Core\Form\FormBuilder->buildForm('system_performance_settings', Object) (Line: 74)
Drupal\Core\Controller\FormController->getContentResult(Object, Object)
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 576)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
call_user_func_array(Object, Array) (Line: 153)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 68)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 57)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 99)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 78)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 50)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 657)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

the_g_bomb made their first commit to this issue’s fork.

the_g_bomb’s picture

Status: Needs work » Needs review

I used drupalmoduleupgrader, some of the original patch in places and some fixes to it as well. Please review the MR.

ricardofaria’s picture

#5 worked for me. No errors on installation.

I tested this module together with the auto logout module. I did 2 tests:
1. In the current tab. It logs me out if i don't touch the mouse for the established time in auto logout.
2. Logged in, changed to another tab in another random website. It also logs me out after the established time.

dtarc’s picture

Updating the patch from #1 to replace `core: 8.x` to `core_version_requirement: ^8.9 || ^9 || ^10` in `ejectorseat.info.yml`.

This is a pretty useful module with high usage for 7.x. I don't know if there's any alternative for D9 but it would be great to get a D9 branch up.

the_g_bomb’s picture

Thanks dtarc, please could you review the merge request instead of uploading a patch that does the same thing
https://git.drupalcode.org/project/ejectorseat/-/merge_requests/1#note_1...

dtarc’s picture

That merge request would put the changes into 7.x branch, I think we'd need a new branch for 8.x or 1.0.0.

dtarc’s picture

Status: Needs review » Reviewed & tested by the community

I have tested Merge Request !1 from #5 and it works great! Also it's compatible with Drupal 10.

The only problem is that the MR is against 7.x-1.x, and instead we'll need a new branch for 8.x-1.x.

Please commit this work to a new branch and release a Drupal 8 / 9 / 10 version.

dtarc’s picture

This Drupal 8 / 9 / 10 module can be included in composer by adding the following to composer.json in repositories:

        {
            "type": "vcs",
            "url": "https://git.drupalcode.org/issue/ejectorseat-2410423.git"
        },

And then run:

composer require drupal/ejectorseat:dev-2410423-ejector-seat-drupal