Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Hi,
Are there any plans to introduce D8 version of this module?
I would like to help you with development of this version or to implement it from scratch.
Comment | File | Size | Author |
---|---|---|---|
#7 | ejectorseat-drupal_8-2410423-7.patch | 11.35 KB | dtarc |
#1 | ejectorseat-drupal_8-2410423-1.patch | 11.29 KB | shkiper |
Issue fork ejectorseat-2410423
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #1
shkiper CreditAttribution: shkiper as a volunteer commentedI've made a Drupal 8 version of this module. Could someone please review my patch?
Comment #2
a.sinitsa CreditAttribution: a.sinitsa commentederrors while installing
The website encountered an unexpected error. Please try again later.ReflectionException: Class \Drupal\ejectorseat\Controller\DefaultController does not exist in ReflectionMethod->__construct() (line 123 of core/lib/Drupal/Core/Entity/EntityResolverManager.php).
Comment #5
the_g_bomb CreditAttribution: the_g_bomb at Cyber-Duck commentedI used drupalmoduleupgrader, some of the original patch in places and some fixes to it as well. Please review the MR.
Comment #6
ricardofaria CreditAttribution: ricardofaria at Cyber-Duck commented#5 worked for me. No errors on installation.
I tested this module together with the auto logout module. I did 2 tests:
1. In the current tab. It logs me out if i don't touch the mouse for the established time in auto logout.
2. Logged in, changed to another tab in another random website. It also logs me out after the established time.
Comment #7
dtarc CreditAttribution: dtarc at Affinity Bridge commentedUpdating the patch from #1 to replace `core: 8.x` to `core_version_requirement: ^8.9 || ^9 || ^10` in `ejectorseat.info.yml`.
This is a pretty useful module with high usage for 7.x. I don't know if there's any alternative for D9 but it would be great to get a D9 branch up.
Comment #8
the_g_bomb CreditAttribution: the_g_bomb at Cyber-Duck commentedThanks dtarc, please could you review the merge request instead of uploading a patch that does the same thing
https://git.drupalcode.org/project/ejectorseat/-/merge_requests/1#note_1...
Comment #9
dtarc CreditAttribution: dtarc at Affinity Bridge commentedThat merge request would put the changes into 7.x branch, I think we'd need a new branch for 8.x or 1.0.0.
Comment #10
dtarc CreditAttribution: dtarc at Affinity Bridge commentedI have tested Merge Request !1 from #5 and it works great! Also it's compatible with Drupal 10.
The only problem is that the MR is against 7.x-1.x, and instead we'll need a new branch for 8.x-1.x.
Please commit this work to a new branch and release a Drupal 8 / 9 / 10 version.
Comment #11
dtarc CreditAttribution: dtarc at Affinity Bridge commentedThis Drupal 8 / 9 / 10 module can be included in composer by adding the following to composer.json in repositories:
And then run:
composer require drupal/ejectorseat:dev-2410423-ejector-seat-drupal