Report output

------ --------------------------------------------------- 
  Line   src/Form/ExtraFieldAddForm.php                     
 ------ --------------------------------------------------- 
  204    Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 
CommentFileSizeAuthor
#5 efs-3108874-5.patch1.78 KBliliet
#2 efs-3108874-2.patch1.69 KBliliet

Comments

liliet created an issue. See original summary.

liliet’s picture

Assigned: liliet » Unassigned
Status: Active » Needs review
Issue tags: +ContributionWeekend2020
StatusFileSize
new1.69 KB
nathandentzau’s picture

@liliet best practice is to have your trait definitions be listed immediately following the class definition:

class ExtraFieldAddForm extends FormBase {

  use MessengerTrait;

  protected $currentStep;


  public function __construct(MessengerInterface $messenger) {
    ...
  }

  ...

}

I'm moving this to need work, other than that once it's fixed this should be good to go for RTBC. Thank you! :)

nathandentzau’s picture

Status: Needs review » Needs work
liliet’s picture

Assigned: Unassigned » liliet
Status: Needs work » Needs review
StatusFileSize
new1.78 KB

Best practice applied

liliet’s picture

Assigned: liliet » Unassigned

artem_antonov’s picture

artem_antonov’s picture

Status: Needs review » Fixed
artem_antonov’s picture

Status: Fixed » Closed (fixed)