In the latest version of views 3.x-dev, the function field_views_field_label returns an array instead of a string. This function is used on line 198 of efq_views.views.inc. On line 253 the array is passed though to a t() function which calls check_plain() resulting is the following warning during installation of the module:
htmlspecialchars() expects parameter 1 to be string, array given in check_plain() (line 1355 of includes/bootstrap.inc).
Call stack:
...
PHP 32. call_user_func_array() includes/module.inc:819
PHP 33. efq_views_views_data() includes/module.inc:819
PHP 34. _efq_views_get_field_data() sites/all/modules/efq_views/efq_views.views.inc:19
PHP 35. t() sites/all/modules/efq_views/efq_views.views.inc:252
PHP 36. check_plain() includes/bootstrap.inc:1355
The applied patch should solve the issue.
Comment | File | Size | Author |
---|---|---|---|
#4 | label_aliases-1198912-4.patch | 1.61 KB | xatoo |
extract_label_from_array.patch | 620 bytes | xatoo | |
Comments
Comment #1
bojanz CreditAttribution: bojanz commentedI'd like to see us use this like Views does now, see field_views_field_default_views_data().
Comment #2
xatoo CreditAttribution: xatoo commentedDo you mean creating aliases for all other labels of a field?
Comment #3
bojanz CreditAttribution: bojanz commentedYes. We want the efq_views experience to be as close to the Views one as possible.
Comment #4
xatoo CreditAttribution: xatoo commentedA first try.
I just put the labels in the same group as the original, since I wouldn't know how and why an alias might apear in another group with efq_views. Or else, how to retrieve that group name.
Comment #5
fabsor CreditAttribution: fabsor commentedThis approach seems fine to me. The patch works fine, so I will set it to RTBC.
Regarding the grouping of aliases: Since there are no support for relationships in efq_views right now, it doesn't make any sense to try and implement it here in my opinion, better to get this in, since it is a major usability oddity =)
Comment #6
bojanz CreditAttribution: bojanz commentedOkay, committed. Thanks!