Problem/Motivation

Classes that are used for styling/adding icons per file type purposes no longer attached to the a tag of the uploaded file

Steps to reproduce

Enable version 2 of this module while using ckeditor 5, you will see that the a tag only has the data-entity-uuid and data-entity-type attributes but not the classes

Proposed resolution

Edit the ckeditor5_plugin js files so that the classes persist

CommentFileSizeAuthor
#12 classes-no-longer-added-in-ckeditor5-plugin-3527494-12.patch23.25 KByara mezher
#6 after-patch.png23.01 KByara mezher
#6 before-patch.png19.23 KByara mezher
#3 classes-no-longer-added-in-ckeditor5-plugin-3527494-3.patch17.59 KByara mezher

Issue fork editor_file-3527494

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

yara mezher created an issue. See original summary.

yara mezher’s picture

yara mezher commented
Issue summary: View changes
yara mezher’s picture

yara mezher commented
StatusFileSize
new classes-no-longer-added-in-ckeditor5-plugin-3527494-3.patch17.59 KB

Attached patch fixes the issue and classes are properly added

yara mezher’s picture

yara mezher commented
Title: Classes automatically added to the link: 'file', 'file--mime-[MIME_TYPE]', 'file--[GENERIC_MIME_TYPE]' in EditorFileDialog.php not being added on the upload file <a> element » Classes automatically added to the link: 'file', 'file--mime-[MIME_TYPE]', 'file--[GENERIC_MIME_TYPE]' in EditorFileDialog.php not being added on the uploaded file <a> element
yara mezher’s picture

yara mezher commented
Status: Active » Needs review
yara mezher’s picture

yara mezher commented
StatusFileSize
new before-patch.png19.23 KB
new after-patch.png23.01 KB
jannakha’s picture

jannakha commented

@yara mezher
thank you for your contribution.
Can you please create a merge request to speedup reviewing and testing process?
here's how: https://www.drupal.org/community/contributor-guide/task/create-a-merge-r...

jannakha’s picture

jannakha commented
Version: 2.0.0-rc2 » 2.1.x-dev
Status: Needs review » Needs work

mrinalini9 made their first commit to this issue’s fork.

mrinalini9 opened merge request !16

mrinalini9’s picture

mrinalini9 commented
Status: Needs work » Needs review

Created MR, please review it.

Thanks!

yara mezher’s picture

yara mezher commented
StatusFileSize
new classes-no-longer-added-in-ckeditor5-plugin-3527494-12.patch23.25 KB

Updated patch for module version 2.1.2