Adding a patch to update the core_version_requirement to include D9.

CommentFileSizeAuthor
#3 d9_patch_editor_advanced_link.png54.55 KBsaschaeggi
#2 3105317-2-drupal9-compatibility.patch422 bytessaschaeggi

Comments

saschaeggi created an issue. See original summary.

saschaeggi’s picture

saschaeggi
he/him
commented
StatusFileSize
new 3105317-2-drupal9-compatibility.patch422 bytes
saschaeggi’s picture

saschaeggi
he/him
commented
Status: Active » Reviewed & tested by the community
StatusFileSize
new d9_patch_editor_advanced_link.png54.55 KB

Tested, RTBC!

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Title: Drupal 9 compatibility » Add core_version_requirement key so the module can be added to Drupal 9, make a release
Issue tags: +Drupal 9 porting day

I've been reviewing the module on Drupal 9 porting day today.

  • I see #3042615: Drupal 9 Deprecated Code Report did not find any issues.
  • I installed Upgrade Status and the latest release of Editor Advanced Link and did not find any issues either (other than this missing key in the info file).
  • I manually reviewed the module code and JS files. The JS libraries used are still supported in Drupal 9.

Would be great to get this patch in and tag a release, so there is explicit Drupal 9 compatibility. Otherwise the module cannot be enabled with composer and installed in Drupal 9.

Thanks a lot!

duaelfr’s picture

duaelfr
he/him
Primary language French
Location Montpellier, France
commented

DuaelFr credited Kristen Pol.

duaelfr’s picture

duaelfr
he/him
Primary language French
Location Montpellier, France
commented

  • saschaeggi authored 41d1d6a on 8.x-1.x 
    Issue #3105317 by saschaeggi, DuaelFr, Gábor Hojtsy, Kristen Pol: Add...
duaelfr’s picture

duaelfr
he/him
Primary language French
Location Montpellier, France
commented
Status: Reviewed & tested by the community » Fixed

Commited, thanks.
I'll take some time to clean the issue queue this morning then I'll make a release.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.