Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I'd like to see revision support added to this module, the editablefields module doesn't quite work with multiple fields.
Comment | File | Size | Author |
---|---|---|---|
#10 | Editable views config.jpg | 97.81 KB | kingdee40 |
Comments
Comment #1
joachim CreditAttribution: joachim commented> I'd like to see revision support added to this module
> the editablefields module doesn't quite work with multiple fields.
Are these two things related? Please read the guidelines for posting issues!
In what way would you like revision support?
Comment #2
kerberos CreditAttribution: kerberos commented[comment retracted, wrong module :)]
-Daniel
Jocuri Android RO
Comment #3
PatchRanger CreditAttribution: PatchRanger commentedKeep in mind that fixing this issue is going to be rewarded by not less than $90: see "90$ bounty for fixing issue of Editable Views module" for reference.
Comment #4
joachim CreditAttribution: joachim commented> In what way would you like revision support?
The OP has not yet explained how revisions would be supported.
Comment #5
kingdee40 CreditAttribution: kingdee40 commentedSo right now you create a view with fields that are editable, when you make any changes to those fields the changes are instantly seen. I need any changes to go thought an approval flow, so when anyone makes changes to fields in the view they are not instantly seen and have to be approved by an admin first. Supporting revisions and the Revisioning module the way editiblefields does would solve this problem.
Comment #6
joachim CreditAttribution: joachim commentedBest way to tackle this might be to add an editable views handler for the 'create new revision' checkbox.
Otherwise, forcing a new revision across the board would require a setting at the level of the whole editable view, which would be fiddly.
Of course, you could do this in code with a form alter, as explained in the docs.
Comment #7
PatchRanger CreditAttribution: PatchRanger commentedSo it appears that there is no need in any patch.
To achieve your goal you should just enable node revisioning for all nodes of a concrete content type as described in Node revisions article and then follow the instructions from Revisioning module tutorial.
Closing as working as designed.
Comment #8
kingdee40 CreditAttribution: kingdee40 commentedWhy was this closed? Revisions are not created when editing fields attached to nodes with this module.
Comment #9
criznach CreditAttribution: criznach commentedI just did some testing on a site I have locally, and when set up properly, editable views does create revisions. You'll need to set your content type's "Create new revision" checkbox and save if you want new nodes to be revisioned. If you have existing nodes where "Create new revision" was not checked, editable views will not trigger new revisions until you check "Create new revision" on the node, and re-save. Once you've done that, editable views will trigger new revisions for each field edit. I didn't test as far as the revisioning and workflow modules, but in theory they should work, because the node's revision flag is indeed saved using the standard mechanism.
If this isn't exactly the workflow you want, I suggest you describe the workflow you want in more detail, either in the issue summary, or the paid services forum. As it's currently written, your issue should be closed.
Comment #10
kingdee40 CreditAttribution: kingdee40 commentedYes, I have verified that "Create new revision" is checked on both the Article content type and also on the individual node. No revisions are created, I am testing this on a clean install with editable views module and drupal's core revision system. I am attaching a screenshot of my views config. Please let me know more detail about your config so we can figure this out.
Comment #11
joachim CreditAttribution: joachim commented(Aside: you're using this to edit a single node at a time? It would be much simpler to just write your own form for that!)
Comment #12
criznach CreditAttribution: criznach commentedOn second thought, I may be mistaken about revisioning working. I saw your reference to editablefields, and that's what my site uses. I see now that the issue is on "editable views", and am no longer confused. :)
I seem to remember something about multiple fields not working in editablefields, but it's working great for me. Maybe give editablefields a shot.
Comment #13
donSchoe CreditAttribution: donSchoe commentedThis module is creating new revisions if you set up your site correctly to do so.
I'd say this "works as desired". (Working for me out of the box with user revisions enabled.)
Comment #14
milossramek CreditAttribution: milossramek commentedHi,
the Editable views module does not create for me a new revision upon save, it only updates the revision time.
A new revision is, however, created when editing a node in the normal way.
he "Create new revision" and "Enable moderation of revisions" options in "Publishing options" of admin/structure/types/manage/nodetype are checked.
I do not see such option in the individual nodes, as mentioned in #10
The revisioning module is mentioned above n this discussion - I do not use it.
My configuration:
Drupal 7.44
Editable Views: Version: 7.x-1.0-beta10
Views: Version: 7.x-3.14
Is there something wrong with my configuration?
thanks in advance
Comment #15
christok CreditAttribution: christok commentedThere's nothing wrong with your configuration. However, it turns out that you can mod editable views to save revisions by adding one line of code to editableviews.module:
$entity->revision = TRUE;
Now obviously this should be done as an actual patch and then value of the entity revision setting should come from the content type's but this hack will get you moving forward if you need a quick and dirty universal solution.
Comment #16
milossramek CreditAttribution: milossramek commentedThank you for your help, it works!
Milos