Several fixes to "read more" link

Applies and provides the listed fixes enhancements.

However it still puts the read more link before the end of the text, after the last paragraph tag, in the cases where (for instance) an h3 or h4 link following.

Other tags that might cause trouble: blockquote, span, ol/ul li...

I successfully installed module for Drupal 5x, and this worked a treat in terms of wrapping 'Read more' onto the end of my node text.

However it didn't remove 'Read more' links from nodes in views that are already displayed in full.

Anyone have a solution for this? Its annoying for users to read an item and click 'Read more' just to be presented with the same content...

In regards to:
1. Add a lead non-breaking space ONLY if "read more" link is inline. In this case the leading non-breaking space should be placed outside the link for design reasons.
I had the same idea when I saw that the link underline reaches into the space before the text. But then I realised that if you style your Read More link with no underline, it's more usable to have the link extend into the space on either side. Easier to click. Just an idea.

By the way maybe someone wants to volunteer to take over the project? The original developer doesn't seem to be following the patches / updates anymore.

@gogik:

I successfully installed module for Drupal 5x, and this worked a treat in terms of wrapping 'Read more' onto the end of my node text.

However it didn't remove 'Read more' links from nodes in views that are already displayed in full.

Anyone have a solution for this? Its annoying for users to read an item and click 'Read more' just to be presented with the same content...

Please see: http://drupal.org/node/266432

Probably due to module ordering issues.

By the way maybe someone wants to volunteer to take over the project? The original developer doesn't seem to be following the patches / updates anymore.

I'm baaa-aack. :D

My lack of presence here has been due to a variety of factors, which are no longer keeping me away.

I would be interested in granting CVS access to qualified developers if others want to help with this module.

@ inactivist I could take a junior co-maintainer role here...

^{benjamin, Agaric Design Collective}

I'm definitely interested in helping out here. I'll have to get my Drupal 5 local installation back online...

@all: Thanks for the recent activity. For some reason, I'm not receiving email notifications for every posting to my issue queues (I'll have to investigate this).

I'll look into these patches and see if they work as advertised.

@benjamin:

Definitely looking for assistance. Have you done any CVS commits and/or other Drupal module work in that role in the past? If so, what modules? Thanks!

@claudiu:

TODO:

* Is </p> the only closing tag that need to be searched when using inline "read more"? Find other "block" tags that need to be searched. </div> can be one of these... Maybe the filter allowed tags var must be queried for this... Find out this!
* Add a new variable (maybe ed_readmore_title) in order to let administrators specify a custom title for the "read more" link.

I would think you would need to look for </div>, br, etc. -- the 'inline' "read more" insertion needs to deal with the last found closing 'block' tag that can cause a line break.

This is one of the reasons why I've not dealt with this issue -- there are multiple cases to deal with if you want to do it properly. So: Either we try to figure out a reasonable approach, or we punt and just say that the module has certain weaknesses. Unfortunately, I've not spent much time trying to analyze the best approach to solving this problem in a clean way (also consider performance issues, as well... this code will be called on very teaser render call.)

Also consider what happens with a non-traditional filter like wiki markup, or bbcode...

I suspect this may be a tougher problem than it appears to be at first glance.. I'll have to think about it, and I'd appreciate other input here. What kinds of issues will we run into with the wide range of input filters in use? Or can we just generalize this and look for a fixed pattern of HTML tags? Or should the pattern be configurable?

I've thought of using a set of configurable regular expressions but I'm not sure what they might be, or if regexp's would hurt performance.

Need info, before we proceed.

I would go for the idea of "module has limitations" rather than covering spurious cases that no-one actually using the module has yet encountered.

I found the Angry Donuts post first, but I decided to use your module instead of custom code because I would like my Drupal installs to be as simple as possible (least custom code) to enhance maintainability for other (perhaps less drupal-savvy) developers. I think this is the main advantage/use of your module so let's keep it lean and fast and let it fit this model of "simplicity".

If a person wants to solve a really special case then they can just go to the Angry Donuts site and use the example there to create custom code for their site.

I might add that we should also be careful of biting off more than we can chew. The module had uncommitted but necessary patches for ages, now we want to expand it to suit wikis etc? Rather keep it simpler but maintain it well.

@fletchgqc:

No, I don't want to expand anything. What I am trying to do is raise awareness that this issue is deeper and wider than people think, and that I'm fine with drawing a line in the sand if the this will meet most users' needs. One must first identify the issues and then ask the question, and that is what I have done. Your feedback helps, but I would like to know if I've missed any compatibility issues before we try to roll another release to deal with this issue.

Regarding patches that are both necessary and 'ready for prime time', and have been so for ages, please identify them (besides this one, of course) so I can focus on them first. I've seen only a few patches that fit my idea of what the module is and should be. I recently committed the Drupal 6 patch, which was the most necessary one AFAIK.

Yeah I mainly meant this one and Drupal 6.

Nice little module - I'm a bit of a Drupal novice, so perhaps excuse the question, but to summarise;

I'm running Drupal 6 and the only issue I have is with the lack of leading non-breaking space to the inline Read more link. I see from the beginning of this post that there's a patch which has fixed this amongst other issues, but will that work on Drupal 6? This thread is for 5.x

Thanks!

Al,

Hi,
Will these patches be committed?

greetings,
Martijn

+1 for commit

Thank you for submitting the patch! I'll test it as soon as I can, and if it's solid, I'll commit it.

I've been swamped and don't have time to properly review, test, and commit these patches right now. I will work on them as soon as I have time to do it properly. Sorry, but that's the way it is right now.

Or is there another qualified developer who wishes to jump in as a co-maintainer (if only for this task) to create a branch and generate a new dev release for this? If so, I'll grant CVS access and you can have at it.

@cladiu.cristea:

OK. Add me as co-maintainer

Thanks for offering to help.

I've granted you CVS access; please limit your changes to this issue for the time being -- generate appropriate CVS tags and create development releases for this patch. Let me know if you want to add anything or make changes to the project page related to this effort.

Has this patch been 'reviewed and tested by the community' ? The current state is 'code needs review'.

Other changes are afoot. Putting this back to 'active'

I've been added as a co-maintainer as part of the Drupal.org upgrade effort. I'll be submitting a number of patches to clean up UI and logic, some of which may solve some issues addressed in this patch.

Can someone update this thread with the version of the module this patch should be applied to?

Nevermind. This patch applied cleanly to 6.x-3.x-dev.

These and other fixes have been added to 6.x-3.x-dev. I should note that some of the changes made by this patch were altered further. Everyone is encouraged to try to dev snapshot for today when it's generated.