Links for details:

CommentFileSizeAuthor
#8 eck-remove_deprecated_code-2939967-8-D8.patch3.81 KBnnevill
#6 eck-remove_deprecated_code-2939967-5-D8.patch3.7 KBnnevill
#3 eck-remove_deprecated_code-2939967-3-D8.patch2.96 KBnnevill
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Matroskeen created an issue. See original summary.

Matroskeen’s picture

Matroskeen
Primary language Ukrainian
Location 🇺🇦 Ukraine, Lutsk
CreditAttribution: Matroskeen as a volunteer and at DevBranch, Drupal Ukraine Community commented
Title: Remove usages of LinkGeneratorTrait and UrlGeneratorTrait » Remove usages of LinkGeneratorTrait, UrlGeneratorTrait and l() method
Issue summary: View changes
nnevill’s picture

nnevill
Primary language Ukrainian
Location Lutsk
CreditAttribution: nnevill at DevBranch, Drupal Ukraine Community for Adyax commented
FileSize
eck-remove_deprecated_code-2939967-3-D8.patch2.96 KB
nnevill’s picture

nnevill
Primary language Ukrainian
Location Lutsk
CreditAttribution: nnevill as a volunteer and at DevBranch, Drupal Ukraine Community commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 3: eck-remove_deprecated_code-2939967-3-D8.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

nnevill’s picture

nnevill
Primary language Ukrainian
Location Lutsk
CreditAttribution: nnevill as a volunteer and at DevBranch, Drupal Ukraine Community commented
Status: Needs work » Needs review
FileSize
eck-remove_deprecated_code-2939967-5-D8.patch3.7 KB
Matroskeen’s picture

Matroskeen
Primary language Ukrainian
Location 🇺🇦 Ukraine, Lutsk
CreditAttribution: Matroskeen as a volunteer and at DevBranch, Drupal Ukraine Community commented
Status: Needs review » Needs work 
12	use Drupal\Component\Utility\Xss;
13	use Drupal\Core\Link;

use statements should be sorted alphabetically.

'@link' => Link::fromTextAndUrl('Add new bundle', new Url('eck.entity.' . $this->entityType->id() . '.add'))->toString(),

Please wrap 'Add new bundle' with t() func.

nnevill’s picture

nnevill
Primary language Ukrainian
Location Lutsk
CreditAttribution: nnevill as a volunteer and at DevBranch, Drupal Ukraine Community commented
Status: Needs work » Needs review
FileSize
eck-remove_deprecated_code-2939967-8-D8.patch3.81 KB

  • Matroskeen committed 3053a53 on 8.x-1.x authored by nnevill 
    Issue #2939967 by nnevill: Remove usages of LinkGeneratorTrait,...
Matroskeen’s picture

Matroskeen
Primary language Ukrainian
Location 🇺🇦 Ukraine, Lutsk
CreditAttribution: Matroskeen as a volunteer and at DevBranch, Drupal Ukraine Community commented
Status: Needs review » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.