Hello --

Adding a new custom entity or editing an existing one always uses the admin theme, regardless of whether you've unchecked the setting to use the admin theme when editing or creating content.

Thanks in advance for any help or feedback. I'd like to help with a patch but I'm pretty new to D8 code and am not sure where to look for this.

CommentFileSizeAuthor
#11 eck-2927308-11.patch1.7 KBMatroskeen
#11 Screen Shot on 2020-06-21 at 13:47:02.png113.57 KBMatroskeen
#3 use-admin-theme-on-eck-content-2927308-3.patch1.91 KBgerzenstl
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ceiadra created an issue. See original summary.

gerzenstl’s picture

gerzenstl CreditAttribution: gerzenstl at 42mate commented
Assigned: Unassigned » gerzenstl
gerzenstl’s picture

gerzenstl CreditAttribution: gerzenstl at 42mate commented
Status: Active » Needs review
FileSize
use-admin-theme-on-eck-content-2927308-3.patch1.91 KB

To fix this issue I used same approach used for node entity.

gerzenstl’s picture

gerzenstl CreditAttribution: gerzenstl at 42mate commented
Related issues: +#2859737: Use admin theme on bundle/ID/edit

Status: Needs review » Needs work

The last submitted patch, 3: use-admin-theme-on-eck-content-2927308-3.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Matroskeen’s picture

Matroskeen
Primary language Ukrainian
Location 🇺🇦 Ukraine, Lutsk
CreditAttribution: Matroskeen as a volunteer and at DevBranch, Drupal Ukraine Community commented
Issue tags: +LutskGSW18
nnevill’s picture

nnevill
Primary language Ukrainian
Location Lutsk
CreditAttribution: nnevill as a volunteer and at DevBranch, Drupal Ukraine Community commented
Assigned: gerzenstl » nnevill
ceiadra’s picture

ceiadra CreditAttribution: ceiadra commented

Thanks for working on this! I tried applying the patch, but it didn't fix the issue. This also seems to be the opposite problem of the related issue linked in #4 -- does it maybe make more sense to work on one branch or the other? I wound up installing the dev branch because I needed the patch for Automatic Entity Label support.

gerzenstl’s picture

gerzenstl CreditAttribution: gerzenstl at 42mate commented

@ceiadra, It worked fine when I tested before submitting the patch. I was using the last version available in the repository of the module.

I'll retest the patch tonight. Thanks!

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs work » Postponed (maintainer needs more info)

Please check the latest -dev snapshot; a new option was added to the Admin -> Appearance page for controlling this option specifically for ECK entities.

Matroskeen’s picture

Matroskeen
Primary language Ukrainian
Location 🇺🇦 Ukraine, Lutsk
CreditAttribution: Matroskeen as a volunteer and at DevBranch, Drupal Ukraine Community commented
Status: Postponed (maintainer needs more info) » Needs review
FileSize
Screen Shot on 2020-06-21 at 13:47:02.png113.57 KB
eck-2927308-11.patch1.7 KB

I believe this issue is no longer exists.
It was fixed in #2859737: Use admin theme on bundle/ID/edit.

As was mentioned previously, the new option is available on "Appearance" page (/admin/appearance).
I'm adding a patch with test that proves this functionality.

  • Matroskeen committed 70be4e1 on 8.x-1.x 
    Issue #2927308 by Matroskeen, gerzenstl, DamienMcKenna: Appearance...
Matroskeen’s picture

Matroskeen
Primary language Ukrainian
Location 🇺🇦 Ukraine, Lutsk
CreditAttribution: Matroskeen as a volunteer and at DevBranch, Drupal Ukraine Community commented
Assigned: nnevill » Unassigned
Status: Needs review » Fixed

I think we can mark this one as "Fixed".

I was curious to run tests for D.9 and PHP 7.3+, but they seem to fail because of completely unrelated reasons.
Here is a follow-up issue: #3153688: Tests fail on PHP 7.3+ and Drupal 9.0+.

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.