Provide some Simpletest for the module on D7 to help with regression testing.

CommentFileSizeAuthor
#10 eck-n2889325-10.interdiff.txt372 bytesDamienMcKenna
#10 eck-n2889325-10.patch24.16 KBDamienMcKenna
#9 eck-n2889325-9.patch24.12 KBDamienMcKenna
#9 eck-n2889325-9.interdiff.txt4.57 KBDamienMcKenna
#7 eck-n2889325-7.interdiff.txt6.62 KBDamienMcKenna
#7 eck-n2889325-7.patch24.1 KBDamienMcKenna
#6 eck-n2889325-6.patch23.7 KBDamienMcKenna
#6 eck-n2889325-6.interdiff.txt1.21 KBDamienMcKenna
#5 eck-n2889325-5.patch23.74 KBDamienMcKenna
#2 eck-n2889325-2.patch23.73 KBDamienMcKenna
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

DamienMcKenna created an issue. See original summary.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Active » Needs review
FileSize
eck-n2889325-2.patch23.73 KB

Tests written for #1798646.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented

The tests cover some basic CRUD actions, translation using Entity Translation, and then translation when attached to a node using EntityReference. So far the basic functionality appears to be working well, even with translations. There's a whole lot more to do to build these out, but this should help with regression testing and create a platform to build upon for the additional changes that are to be added to the 7.x-2.x branch.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented

ICBW but I think if we also had tests for the permissions structure we'd then be able to ditch the behat tests entirely.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
FileSize
eck-n2889325-5.patch23.74 KB

Wrong filenames. Duh.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
FileSize
eck-n2889325-6.interdiff.txt1.21 KB
eck-n2889325-6.patch23.7 KB

Only one test file was picked up that time, lets see if this fixes the problem.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
FileSize
eck-n2889325-7.patch24.1 KB
eck-n2889325-7.interdiff.txt6.62 KB

Further improvements.

Status: Needs review » Needs work

The last submitted patch, 7: eck-n2889325-7.patch, failed testing. View results

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs work » Needs review
FileSize
eck-n2889325-9.interdiff.txt4.57 KB
eck-n2889325-9.patch24.12 KB

Duh, Damien, OOP basics.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
FileSize
eck-n2889325-10.patch24.16 KB
eck-n2889325-10.interdiff.txt372 bytes

It isn't picking up the translation tests because of a missing test dependency.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented

Once the test_dependencies[] lines are committed it'll then run the translation tests too.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented

Rerunning the tests to make sure it still all works.

pifagor’s picture

pifagor
Location 🇺🇦 Rivne
CreditAttribution: pifagor at GOLEMS GABB for GOLEMS GABB commented
Status: Needs review » Reviewed & tested by the community

+1

pifagor’s picture

pifagor
Location 🇺🇦 Rivne
CreditAttribution: pifagor at GOLEMS GABB for GOLEMS GABB commented

pifagor’s picture

pifagor
Location 🇺🇦 Rivne
CreditAttribution: pifagor at GOLEMS GABB for GOLEMS GABB commented
Status: Reviewed & tested by the community » Fixed
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented

Excellent! Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.