Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Hi, Entity Construction Kit is not setting the admin theme on $bundle/$id/edit paths. Would be possible to set it automatically like the add path which is already using the admin theme?
Thanks.
Comment | File | Size | Author |
---|---|---|---|
#13 | eck-use_admin_form-2859737-13.patch | 1.41 KB | NickDickinsonWilde |
#9 | interdiff-2859737-8-9.txt | 356 bytes | nnevill |
#9 | eck-use_admin_form-2859737-9.patch | 5.97 KB | nnevill |
|
Comments
Comment #2
liquidgnome CreditAttribution: liquidgnome commentedseems like this patch ought to help, at least it helped in my situation. it's my first patch, though, so i couldn't tell you if i did it remotely according to best practice.
Comment #3
friera CreditAttribution: friera as a volunteer commentedIt doesn't work for me. I provide a new patch to solve that.
Comment #4
FiNeX CreditAttribution: FiNeX as a volunteer commentedThe patch works :-)
Comment #5
OnkelTem CreditAttribution: OnkelTem commentedI haven't tried it yet but I don't think that just moving it under admin is the correct approach.
Comment #6
OnkelTem CreditAttribution: OnkelTem commentedUploading a patch. It works pretty much like node, i.e. on Appearance page added a checkbox to use Admin theme for ECK entities.
Comment #8
OnkelTem CreditAttribution: OnkelTem commentedThe previous patch was not finished (missed some edits).
Comment #9
nnevillComment #10
MatroskeenAdded missing tag :)
Comment #12
MatroskeenHello,
It works well for me. Sure, it will be great to have additional tests for this feature.
Let's move to "Needs work" for tests.
Comment #13
NickDickinsonWildeURGENT! As committed, that breaks dev.
There was a new file not committed.
Patch attached, with just that change.
Comment #16
MatroskeenMy bad, sorry.
@NickWilde, thanks for your reactivity. Committed to 8.x-1.x.
Comment #17
frobFrom what I can tell this should be closed. @Matroskeen please change if that isn't the case.
Comment #18
MatroskeenActually, I'm not sure what is the best way.
I would like to cover all functionality with tests.
Otherwise, I prefer do not slow down the whole process and commit working stuff without tests.
So, how to deal with this case?
Maybe there is a reason to add child issues for tests only?