Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Alot of the fields in \Drupal\eck\Entity\EckEntity::baseFieldDefinitions
could be dropped by calling out to the parent method.
Proposed resolution
Let's try that out.
Remaining tasks
User interface changes
API changes
Data model changes
Comment | File | Size | Author |
---|---|---|---|
#10 | refactor-2797789-10.patch | 17.03 KB | legolasbo |
#9 | interdiff-6-9.txt | 473 bytes | legolasbo |
#9 | refactor-2797789-9.patch | 17.21 KB | legolasbo |
#6 | refactor-2797789-6.patch | 17.19 KB | legolasbo |
#2 | refactor-2797789-2.patch | 17.19 KB | legolasbo |
Comments
Comment #2
legolasboAttached patch adds tests for the baseFieldDefinitions and calls out to the parent method for the default entity fields.
Comment #3
dawehnerThat's a change which is unrelated IMHO. Feel free to do so though. I'm a huge fan of optimizing for reviewablity, aka. change one thing at a time.
Comment #6
legolasboRerolled the patch, lets see what happens.
Comment #9
legolasboAdded the missing @group annotation.
Comment #10
legolasboPerformed the refactoring in a separate issue ([#2825144)] as suggested in #3 and rerolled the patch.
Comment #11
dawehnernote: on the longrun you can use
TranslatableMarkup::create()
, out of scope of this issue of course.Comment #13
legolasboCommitted and pushed to 8.x-1.x. Thanks for reviewing dawehner.