Upon save of entity check if taxonomy term exists, if it does then get tid.

CommentFileSizeAuthor
#6 Screen Shot 2018-09-28 at 11.33.46.png25.04 KBchandraraj
#5 Tags___Drupal_standard.png101.35 KBaburrows
#5 no-duplicate-terms-2945343-5.patch4.22 KBaburrows
#2 no-duplicate-terms-2945343-2.patch4.22 KBaburrows
#2 sequelpro_spf_—__MySQL_5_5_5-10_1_32-MariaDB__drud_8xdevcontrib_ddev_local_db_eat.png48.08 KBaburrows
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

aburrows created an issue. See original summary.

aburrows’s picture

aburrows CreditAttribution: aburrows at DigiDrop commented
Status: Active » Needs review
FileSize
sequelpro_spf_—__MySQL_5_5_5-10_1_32-MariaDB__drud_8xdevcontrib_ddev_local_db_eat.png48.08 KB
no-duplicate-terms-2945343-2.patch4.22 KB

So I've added some extra checks and a new method into the Eat.php class this upon testing resolves. As can be seen in the screenshot the DB has mutliple entries and tid of 3 is the same term.

Please test on your site, and feedback anything so this can be committed.

aburrows’s picture

aburrows CreditAttribution: aburrows at DigiDrop commented
Assigned: aburrows » Unassigned
chandraraj’s picture

chandraraj CreditAttribution: chandraraj commented

Tested the patch. I'm afraid i've got an warning issue. No term is created too.

Deprecated function: Non-static method Drupal\eat\Eat::checkIfExists() should not be called statically in eat_form_submit() (line 66 of modules/contrib/eat/eat.module).

eat_form_submit(Array, Object)
call_user_func_array('eat_form_submit', Array) (Line: 111)
Drupal\Core\Form\FormSubmitter->executeSubmitHandlers(Array, Object) (Line: 51)
Drupal\Core\Form\FormSubmitter->doSubmitForm(Array, Object) (Line: 589)
Drupal\Core\Form\FormBuilder->processForm('node_subject_form', Array, Object) (Line: 318)
Drupal\Core\Form\FormBuilder->buildForm('node_subject_form', Object) (Line: 48)
Drupal\Core\Entity\EntityFormBuilder->getForm(Object) (Line: 113)
Drupal\node\Controller\NodeController->add(Object)
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 582)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 151)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 68)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 57)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 99)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 78)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 52)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 665)
Drupal\Core\DrupalKernel->handle(Object) (Line: 25)
aburrows’s picture

aburrows CreditAttribution: aburrows at DigiDrop commented
FileSize
no-duplicate-terms-2945343-5.patch4.22 KB
Tags___Drupal_standard.png101.35 KB

I've re-tested on simpytest and its working fine, please test again on a clean Drupal 8.6x install.
Updated patch to include static method.

chandraraj’s picture

chandraraj CreditAttribution: chandraraj commented
FileSize
Screen Shot 2018-09-28 at 11.33.46.png25.04 KB

Thanks aburrows,

I've tested the patch in our site and a clean 8.6.1 site. Seems to be working

  • aburrows committed deb9e72 on 8.x-2.x 
    Issue #2945343 by aburrows: Don't allow duplication of a name on a...
aburrows’s picture

aburrows CreditAttribution: aburrows at DigiDrop commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.