Problem/Motivation

The logo that is used on emails comes from the easy email theme. It feels feel weird that after uploading your logo to your front end theme is doesn't automatically update... it would be neat it if it.

Steps to reproduce

Proposed resolution

Update the easy email theme logo if it using the default logo when you change the front end logo.

Or provide a button or a way to set the email logo from the front end theme setting page to update the email logo to match the one used in the front end.

Or change the easy email theme to use the front end logo by default and only use a custom logo if it is overridden.

User interface changes

Configuration changes

Issue fork easy_email_theme-3515767

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alexpott created an issue. See original summary.

pameeela’s picture

pameeela commented
Project: Drupal CMS development repository » Easy Email
Version: » 3.0.x-dev
Component: Base Recipe » Code
Category: Task » Feature request
Issue summary: View changes

Thanks, I had no idea it used a separate logo.

Or change the easy email theme to use the front end logo by default and only use a custom logo if it is overridden.

This makes a lot of sense to me, it seems like setting a custom logo is an edge case. Moving over to the module queue though since it'll have to happen there.

pameeela’s picture

pameeela commented
Title: Email logo is hard to know where to set » Use site logo by default instead of always setting a separate one
zengenuity’s picture

zengenuity commented
Project: Easy Email » Easy Email Theme
Version: 3.0.x-dev » 1.0.x-dev

This is handled in Easy Email Theme. Moving it there.

pameeela’s picture

pameeela commented

Thanks!

zengenuity opened merge request !2

zengenuity’s picture

zengenuity commented
Status: Active » Needs review

@alexpott, @pameeela: I've implemented this functionality in Easy Email Theme. Now, when the "Use the logo supplied by the theme" option is checked in Easy Email Theme, it will attempt to use the logo configured in the default theme. (whether that is uploaded or a default)

One thing I noticed while doing this is that Drupal CMS Olivero doesn't have a default logo.svg file. So, if we merge this change, then all DCMS sites are going to start out with no logo in their emails. In that case, they get the linked site name in that same place instead.

pameeela’s picture

pameeela commented

Ah, thanks for the heads up! I'll create an issue for adding the logo.

zengenuity’s picture

zengenuity commented

This has to be merged along with #3545277: Hide Easy Email Theme from Appearance and Block layout pages, because once that's merged, we won't be able to access the theme logo settings.

  • zengenuity committed 996506be on 1.0.x 
    #3515767 - Use the default logo from the default theme rather than...
zengenuity’s picture

zengenuity commented
Status: Needs review » Fixed

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

pameeela’s picture

pameeela commented

Thanks! I've updated the Drupal CMS issue with an MR to fix the missing logo.

zengenuity’s picture

zengenuity commented

I've created a new release for this change.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.