In hook_install you're creating a route to help.page. That route only exists if the help module is installed. Please add a check around the help message part in hook_install:

  $messenger = \Drupal::messenger();
  $settings_url = Url::fromRoute('easy_breadcrumb.general_settings_form')->toString();
  $help_url = Url::fromRoute('help.page', ['name' => 'easy_breadcrumb'])->toString();

  $messenger->addMessage("Easy Breadcrumb settings are found on $settings_url.");
  $messenger->addMessage("Easy Breadcrumb documentation is found on $help_url.");

Comments

Grayle created an issue. See original summary.

grayle’s picture

StatusFileSize
new1.02 KB
sunlix’s picture

Oh yes please. This breaked our site installation via drush site:install profile_name
easy_breadcrumb is a default module in our projects. :)

alexdmccabe’s picture

Status: Active » Needs review
StatusFileSize
new1.55 KB
new1.31 KB

Rerolled the patch to keep the message, catch the exception, and provide a link to install the module if the exception happens.

greg boggs’s picture

I didn't realize help could be turned off. Pushing a fix and rolling a new release.

greg boggs’s picture

I went ahead and pushed a new tag for 8.1.11. Can someone confirm that the install works before I publish the release on D.O.? Instead of going with the try catch, I just removed the call to the help module path and linked to the documentation on Drupal.org. I still credited you as the author of course :)

greg boggs’s picture

Went ahead and published since there was an upgrade path bug as well:

https://www.drupal.org/project/easy_breadcrumb/releases/8.x-1.12

greg boggs’s picture

Status: Needs review » Fixed

Lemme know if I missed anything!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.