Problem/Motivation

We are shipping with the following configuration:

  • include_invalid_paths: TRUE
  • include_title_segment: TRUE

In that case we end up with an empty breadcrumb on the frontpage: 

[[
'title' => '',
'path' => '',
]]

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 2883772-2.patch2.73 KBdawehner
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner created an issue. See original summary.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer and for TES Global commented
Status: Active » Needs review
FileSize
2883772-2.patch2.73 KB
Greg Boggs’s picture

Greg Boggs
he/him
Primary language English
Location Portland Oregon
CreditAttribution: Greg Boggs at ThinkShout commented

Thanks! Nice catch, and thank you also for the automated test. In the case of an empty crumb, that generates a wrapper or something when it shouldn't?

~Greg

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer and for TES Global commented

Thanks! Nice catch, and thank you also for the automated test. In the case of an empty crumb, that generates a wrapper or something when it shouldn't?

Yeah basically, I mean it depends on your template, but {% if breadcrumb %} would certainly not produce what you expect it to do.

  • Greg Boggs committed 70820c3 on 8.x-1.x authored by dawehner 
    Issue #2883772 by dawehner, Greg Boggs: Frontpage spits out an empty...
Greg Boggs’s picture

Greg Boggs
he/him
Primary language English
Location Portland Oregon
CreditAttribution: Greg Boggs at ThinkShout commented

Looks good. Thanks again for kicking off a working test too.

~Greg

Greg Boggs’s picture

Greg Boggs
he/him
Primary language English
Location Portland Oregon
CreditAttribution: Greg Boggs at ThinkShout commented
Status: Needs review » Fixed
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer and for TES Global commented

Thank you @Greg Boggs!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.