Follow-up to #2839178: Fix incorrect DER field dependency calculation

Problem/Motivation

DER field doesn't add dependencies to the target bundles.

Proposed resolution

Update DERI::calculateDependencies() and DERI::onDependencyRemoval() to add dependencies to the target bundles.

Remaining tasks

  • Review.
  • Commit.

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#5 fix_incorrect_der_field-2878852-5.patch14.28 KBjibran
#4 fix_incorrect_der_field-2878852-4.patch16.21 KBjibran
#2 fix_incorrect_der_field-2878852-2.patch5.47 KBjibran

Comments

jibran created an issue. See original summary.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
StatusFileSize
new fix_incorrect_der_field-2878852-2.patch5.47 KB
jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Active » Needs review
jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Issue summary: View changes
StatusFileSize
new fix_incorrect_der_field-2878852-4.patch16.21 KB

With upgrade path and tests now.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
StatusFileSize
new fix_incorrect_der_field-2878852-5.patch14.28 KB

Patch for 8.x-2.x without the upgrade path.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

looks good to me

dpi’s picture

dpi
Location Perth, Australia
commented
Status: Needs review » Reviewed & tested by the community

  • jibran committed ac86b98 on 8.x-2.x 
    Issue #2878852 by jibran: Fix incorrect DER field config dependency...

  • jibran committed ccd4f45 on 8.x-1.x 
    Issue #2878852 by jibran: Fix incorrect DER field config dependency...
jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Reviewed & tested by the community » Fixed

Thanks, @larowlan and @dpi for the review.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.