List of view_modes is empty in dynamic_entity_reference_entity_view formatter

Nice catch. We need tests here.

There is #2381993: Allow view mode or formatter to be selected per item in the widget to move this to widgets

I have a similar problem as described in #2743487: Allow more display modes besides default for "rendered entity" format.
I've tested this patch and it works for me. The dropdown menu now displays all those display modes that the selected entities have in common, including custom ones.

Patch with test coverage.

Remove unused imports and unnecessary permissions.

Great progress! Few things:

1. +++ b/src/Plugin/Field/FieldFormatter/DynamicEntityReferenceEntityFormatter.php
   @@ -28,4 +29,36 @@ class DynamicEntityReferenceEntityFormatter extends EntityReferenceEntityFormatt
   +    $options = array();
   ...
   +    $available_view_modes = array();
   ...
   +    $elements['view_mode'] = array(
   

   It seems that the short array syntax is used in other classes of the module. Let's be consistent.

2. +++ b/src/Plugin/Field/FieldFormatter/DynamicEntityReferenceEntityFormatter.php
   @@ -28,4 +29,36 @@ class DynamicEntityReferenceEntityFormatter extends EntityReferenceEntityFormatt
   +    $entity_type_ids = $this->getFieldSetting('entity_type_ids');
   

   We should consider the case where selection is negated ("Exclude" checkbox is enabled).

   Also add test coverage for that.

3. +++ b/src/Plugin/Field/FieldFormatter/DynamicEntityReferenceEntityFormatter.php
   @@ -28,4 +29,36 @@ class DynamicEntityReferenceEntityFormatter extends EntityReferenceEntityFormatt
   +    foreach ($options as $option_key => $option_value) {
   +      foreach ($available_view_modes as $available_view_mode) {
   +        if (!array_key_exists($option_key, $available_view_mode)) {
   +          unset($options[$option_key]);
   +        }
   +      }
   +    }
   

   I assume that this creates intersection of view modes for all enabled types.

   I think that it would be better to leave all view modes in there and add a description that would explain that the "Default" view mode will be used if the selected one doesn't exist for a given view mode.

   Would also be nice to test this case.

Thanks @CTaPByK for the patch and thank you @slashrsm for the review. Yes, please use array short syntax everywhere.
I think we should have per entity type view mode.
node: teaser
user: default
taxonomy_term: term
Having one select field or multi-select field doesn't make much sense imo.

Per entity view mode.

+++ b/src/Plugin/Field/FieldFormatter/DynamicEntityReferenceEntityFormatter.php
@@ -28,4 +30,22 @@ class DynamicEntityReferenceEntityFormatter extends EntityReferenceEntityFormatt
+        '#default_value' => $this->getSetting('view_mode'),

We have to update default setting as well.

We also have to override the viewElements to actually use it.

We also have to override the viewElements to actually use it.

Yes. And if view mode configuration for a given entity type is missing we use default I assume.

Default settings is updated also as viewElements and tests.

Thanks for the updated patch only thing remaining is #15 i.e. override defaultSettings in DynamicEntityReferenceEntityFormatter

Yes my mistake, now defaultSettings is overridden.

Thanks for the patch.

+++ b/src/Plugin/Field/FieldFormatter/DynamicEntityReferenceEntityFormatter.php
@@ -34,9 +34,28 @@ class DynamicEntityReferenceEntityFormatter extends EntityReferenceEntityFormatt
+    $view_mode = array_fill_keys($options, 'default');
+    return [
+      'view_mode' => $view_mode,
+      'link' => FALSE,
+    ] + parent::defaultSettings();

I think this should be just
return array_fill_keys($options, ['view_mode' => 'default', 'link' => FALSE]). The parent doesn't give us anything so just leave it. Every view mode should have link setting and it is keyed by entity_type. Example can be seen at \Drupal\dynamic_entity_reference\Plugin\Field\FieldType\DynamicEntityReferenceItem::defaultFieldSettings();.

Yes, i change link from bool to sequence of bool, default settings are updated and schema also.

I meant like this.

Oh, ok, then i will fix failing test.

Test is fixed i think and settingsSummary method is also fixed.

Thanks! for fixing the fails. Almost there. I made some minor string changes. Let's add some asserts related to these in testFieldFormatterViewModes.

1. +++ b/tests/src/FunctionalJavascript/DynamicEntityReferenceTest.php
   @@ -187,6 +190,64 @@ class DynamicEntityReferenceTest extends JavascriptTestBase {
   +    $assert_session->optionExists('fields[field_foobar][settings_edit_form][settings][user][view_mode]', 'full', $page);
   ...
   +    $assert_session->optionExists('fields[field_foobar][settings_edit_form][settings][node][view_mode]', 'teaser', $page);
   

   Let's press update and assert the settings summary.

2. +++ b/tests/src/FunctionalJavascript/DynamicEntityReferenceTest.php
   @@ -187,6 +190,64 @@ class DynamicEntityReferenceTest extends JavascriptTestBase {
   +    $assert_session->selectExists('fields[field_foobar][settings_edit_form][settings][user][view_mode]', $page);
   ...
   +    $assert_session->selectExists('fields[field_foobar][settings_edit_form][settings][entity_test][view_mode]', $page);
   ...
   +    $assert_session->selectExists('fields[field_foobar][settings_edit_form][settings][entity_test_with_bundle][view_mode]', $page);
   ...
   +    $assert_session->selectExists('fields[field_foobar][settings_edit_form][settings][node][view_mode]', $page);
   

   We should also check the labels of the select fields.

Marked #2377841: Allow user to chose per entity type formatter. as a duplicate.

Check updating summary and labels are inserted in test. Test is green in my localhost.

Maybe this will fix it.

Now we have different fails.

Yes, i will try to remove this check of default view mode, but however its hard to test when test is pass in my localhost.

Test is still green locally, but lets try like this.

Have you tested it PHP 5.5? I have PHP 7 and it didn't fail for me as well.

Im testing also in php 7, but a can switch quickly on 5.5. When i finish i will comment.

Im tested with php 5.6 and test is green then i tested with php 5.5 and fails exactly like here, with same message...

I think this is will fix that fails. Actually, ARRAY_FILTER_USE_KEY work from php 5.6.

Yeah just looked at it http://php.net/manual/en/array.constants.php#constant.array-filter-use-key.

Thanks for fixing the fails.

+++ b/tests/src/Kernel/DynamicEntityReferenceFormatterTest.php
@@ -182,6 +182,7 @@ class DynamicEntityReferenceFormatterTest extends EntityKernelTestBase {
@@ -212,7 +213,12 @@ class DynamicEntityReferenceFormatterTest extends EntityKernelTestBase {

@@ -212,7 +213,12 @@ class DynamicEntityReferenceFormatterTest extends EntityKernelTestBase {
+    $build = $this->buildRenderArray([$this->referencedEntity, $this->unsavedReferencedEntity], $formatter, [
+      'view_mode' => [
+        $this->referencedEntity->getEntityTypeId() => 'default',
+        $this->unsavedReferencedEntity->getEntityTypeId() => 'default',
+      ],

These are not correct.

Fixed #43. I think we should expand this test a little.

I update the format summary text a bit, did some manual testing. Here are the screenshots.
Formatter settings

Formatter rendring

Thank you! committed and pushed to both branches.

The is an upgrade path for this change in open open_social. https://github.com/goalgorilla/open_social/blob/8.x-1.x/modules/social_f...