Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
In 1.17 of the simplesamlphp library some classes were deprecated.
We should replace those.
Some I've come across.
- SimpleSAML_Auth_Source -> SimpleSAML\Auth\Source
- SimpleSAML_Auth_State -> SimpleSAML\Auth\State
- 'SimpleSAML_Auth_State_exceptionId' -> \SimpleSAML\Auth\State::EXCEPTION_PARAM
Comment | File | Size | Author |
---|---|---|---|
#7 | dvg_authentication-fix_simplesaml_1.17_deprecations-3092770-7.patch | 502 bytes | TVoesenek |
#3 | interdiff-2-3.txt | 615 bytes | TVoesenek |
#3 | dvg_authentication-fix_simplesaml_1.17_deprecations-3092770-3.patch | 4.71 KB | TVoesenek |
Comments
Comment #2
paulvandenburg CreditAttribution: paulvandenburg at iO commentedFixes the deprecations.
Comment #3
TVoesenek CreditAttribution: TVoesenek at iO commentedA small nit:
The State class doesn't need to be namespaced here, as it's already specified in the use statement at the top of the file.
I've changed in this patch (see interdiff-2-3.txt)
Comment #4
paulvandenburg CreditAttribution: paulvandenburg at iO commentedLooks good!
Comment #6
paulvandenburg CreditAttribution: paulvandenburg at iO commentedComment #7
TVoesenek CreditAttribution: TVoesenek at iO commentedThe patch throws a class not found error on the hook_init() of the module. Loading the simplesamlphp library in the hook fixes that.
Comment #8
paulvandenburg CreditAttribution: paulvandenburg at iO commentedLooks good, confirmed working.
Comment #10
paulvandenburg CreditAttribution: paulvandenburg at iO commented