In 1.17 of the simplesamlphp library some classes were deprecated.
We should replace those.

Some I've come across.

  • SimpleSAML_Auth_Source -> SimpleSAML\Auth\Source
  • SimpleSAML_Auth_State -> SimpleSAML\Auth\State
  • 'SimpleSAML_Auth_State_exceptionId' -> \SimpleSAML\Auth\State::EXCEPTION_PARAM
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

paulvandenburg created an issue. See original summary.

paulvandenburg’s picture

Status: Active » Needs review
FileSize
4.73 KB

Fixes the deprecations.

TVoesenek’s picture

A small nit:

+++ b/src/SamlAuthenticationProviderBase.php
@@ -416,7 +416,7 @@ abstract class SamlAuthenticationProviderBase extends AuthenticationProviderBase
+      $msg_args = ['!exception' => var_export($_GET[\SimpleSAML\Auth\State::EXCEPTION_PARAM], 1)];

The State class doesn't need to be namespaced here, as it's already specified in the use statement at the top of the file.

I've changed in this patch (see interdiff-2-3.txt)

paulvandenburg’s picture

Status: Needs review » Reviewed & tested by the community

Looks good!

  • paulvandenburg committed 8728c39 on 7.x-1.x
    Issue #3092770 by TVoesenek, paulvandenburg: Deprecations since...
paulvandenburg’s picture

Status: Reviewed & tested by the community » Fixed
TVoesenek’s picture

Status: Fixed » Needs review
FileSize
502 bytes

The patch throws a class not found error on the hook_init() of the module. Loading the simplesamlphp library in the hook fixes that.

paulvandenburg’s picture

Status: Needs review » Reviewed & tested by the community

Looks good, confirmed working.

paulvandenburg’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.