Our logs are cluttered with notices like this.

Notice: Undefined index: a in _webform_display_wa_product()
Warning: Illegal string offset 'product' in _webform_display_wa_product()
Warning: Illegal string offset 'count' in _webform_display_wa_product()

A simple check fixes this.

CommentFileSizeAuthor
#2 prevent_notices_in-2689119-2.patch681 bytesBarisW
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

BarisW created an issue. See original summary.

BarisW’s picture

Status: Active » Needs review
FileSize
681 bytes
MrHaroldA’s picture

This is fixed in dvg_appointments in issue #2644446: Submission display does not render correctly with this patch: http://cgit.drupalcode.org/dvg_appointments/commit/?id=f757e5e

The issues proved to be a little bigger than adding the isset(); for example, the number of products does not match it's heading:

Product 1/3
Product 2/3

... and it never lists a third product.

DvG Appointments is approaching a state that it will render webform_appointments obsolete. So I'm not sure if we should add this incomplete patch to this module.

MrHaroldA’s picture

Status: Needs review » Postponed
mvwensen’s picture

Status: Postponed » Closed (outdated)

Projects using webform appointments should migrate to DvG Appointments, a lot of issues are fixed.