Imagecache presets loading from code get the default 300x300

Patch applies fine, and apparently gets the width correctly, but the height is not correctly detected, it gets the same height as the width.

Just a pointer that might be helpful, in my module galleryformatter I have a similar function, perhaps you'll find it useful:

/**
  * Helper function to get dimensions of an image
  *
  * @return array
  * An array key => value pairs
  * width => value and height => value, not including px
  */
function galleryformatter_getimage_dimensions($presetname, $image_path) {
  // generate the imagecache preset image path
  $transformed_path = imagecache_create_path($presetname, $image_path);
  // grab the preset itself
  $preset = imagecache_preset_by_name($presetname);

  // get the default presets names provided by galleryformatter
  foreach (galleryformatter_imagecache_default_presets() as $key => $value) {
    $default_presets[] = $value['presetname'];
  }
  // if using the default preset no need to get image info
  $default_preset = in_array($preset['presetname'], $default_presets);
  if (($preset['storage'] == 1) && $default_preset){
    $ret['height'] = $preset['actions'][0]['data']['height'];
    $ret['width'] = $preset['actions'][0]['data']['width'];
  }
  // otherwise check if file exists, or create it so we can get the image dimensions
  elseif (file_exists($transformed_path) || imagecache_build_derivative($preset['actions'], $image_path, $transformed_path)) {
    // grab the image information
    $image = image_get_info($transformed_path);
    $ret['height'] = $image['height'];
    $ret['width'] = $image['width'];
  }
  return $ret;
}

A sample default preset wehre the dummy image gets the same height as its width with the patch:

$presets['largethumbnail'] = array (
    'presetname' => 'Large thumbnail',
    'actions' =>
    array (
      0 =>
      array (
        'weight' => '0',
        'module' => 'imagecache',
        'action' => 'imagecache_scale_and_crop',
        'data' =>
        array (
          'width' => '192px',
          'height' => '115px',
        ),
      ),
    ),
  );

we've just found out that if the default preset DOESN'T have 'px' in its width/height, the patch works properly.

I think the patch is good to go. Having px in the presets is no use and a bad idea, but that's something that should be tackled in imageacache itself i suppose.