Problem/Motivation

\Drupal\ds\Plugin\DsField\Field has a lot of complex code to deal with constructing some wrapper.
This has a couple of issues:

  • Hard to maintain code
  • XSS filter will be run on it, so there are limited HTML tags allowed

Proposed resolution

  • Use an inline template, which does the escaping automatically
  • Note: this was agreed on by talking with Alex

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#13 2820599-13.patch2.91 KBbceyssens
#10 interdiff.txt401 bytesdawehner
#10 2820599-10.patch2.03 KBdawehner
#6 2820599-6.patch2.03 KBdawehner
#2 2820599-2.patch2.4 KBdawehner
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner created an issue. See original summary.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer and at Chapter Three commented
FileSize
2820599-2.patch2.4 KB

Status: Needs review » Needs work

The last submitted patch, 2: 2820599-2.patch, failed testing.

The last submitted patch, 2: 2820599-2.patch, failed testing.

The last submitted patch, 2: 2820599-2.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer and at Chapter Three commented
Status: Needs work » Needs review
FileSize
2820599-6.patch2.03 KB

Here is a reroll.

Status: Needs review » Needs work

The last submitted patch, 6: 2820599-6.patch, failed testing.

The last submitted patch, 6: 2820599-6.patch, failed testing.

The last submitted patch, 6: 2820599-6.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer and at Chapter Three commented
Status: Needs work » Needs review
FileSize
2820599-10.patch2.03 KB
interdiff.txt401 bytes

Here is a small bug fix :)

Status: Needs review » Needs work

The last submitted patch, 10: 2820599-10.patch, failed testing.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented

Almost ;)

bceyssens’s picture

bceyssens
Primary language Dutch
Location Genk 🇧🇪
CreditAttribution: bceyssens at Nascom commented
Status: Needs work » Needs review
FileSize
2820599-13.patch2.91 KB

  • dawehner authored d66c2ad on 8.x-3.x 
    Issue #2820599 by dawehner, bceyssens: \Drupal\ds\Plugin\DsField\Field...

  • dawehner authored 065df3e on 8.x-2.x 
    Issue #2820599 by dawehner, bceyssens: \Drupal\ds\Plugin\DsField\Field...
bceyssens’s picture

bceyssens
Primary language Dutch
Location Genk 🇧🇪
CreditAttribution: bceyssens at Nascom commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.