Convert for Drush 8/9/console

Hello,

I am trying to apply your patch, but the commands are not detected.

My project structure is as follow:
- drush/commands/drush_language
- src/core, etc.
- composer.json
- bin (from composer)
- vendor

I tried creating a drush.yml config file into the drush folder at the root of my project, the drush config file is detected by drush when I run drush status.

I tried putting in the drush.yml:

drush:
  paths:
    # Specify folders to search for Drush command files.  These locations
    # are always merged with include paths defined on the command line or
    # in other configuration files.  On the command line, paths may be separated
    # by a colon (:) on Unix-based systems or a semi-colon (;) on Windows,
    # or multiple --include options may be provided. Note that the locations shown
    # in the example below were searched by default in Drush 8 and earlier.
    include:
#      - './commands'
#      - './commands/drush_language'
      - 'ABSOLUTE_PATH_TO_PROJECT/drush/commands'
      - 'ABSOLUTE_PATH_TO_PROJECT/drush/commands/drush_language'

After clearing caches each time, I can't see the command when running Drush.

Does drush_language needs to be in a specific folder?

Thanks for any help.

Sorry, I didn't take attention to the new README.md file...

Ok. I got error on PHP 5.6 environment I will upload an updated patch.

Here is the updated patch and the interdiff.

Thanks for the review.

Hello,

As I have projects at work and personal (Drupalfr site) that are on PHP 5.6, I would prefer the code to support PHP 5.6. Also Drupal 8 Core is compatible with PHP 5.6.

Yes, I would prefer having all the Drupal projects on Earth on PHP 7 but I can't control that :).

About the indentation, sorry I didn't particularly mean to change that, just changes from the IDE when copy pasting.

Great you work on this!! No time today for a thorough review, but a quick shot: Did you read this:
http://nuvole.org/blog/2017/oct/13/how-maintain-drush-commands-drush-8-a...

It would save us forking a new version, and i'd love to commit it that way if feasible...

Hello,

I test patch #8 it's good for me.

@fgm: Thank you very much for the link.

Great you hacked this together and can use it. As stated in #13 for inclusion this needswork.

#13 elaborated: As a maintainer, i see the issue that this patch will introduce code duplicated in 2 places which makes any subsequent patch cumbersome and error-prone. Fortunately the config-split guys have solved that problem well and - even better - documented their effort. It's super simple!
So if this patch is reworked that way, we can move it in.

Here is a patch from the PR https://github.com/dawehner/drush_language/pull/18 last version applied on the drupal.org git repository last dev version.

I will try to create the service and make the factorisation. Hope it will be merged...

I will push the commits into https://github.com/FlorentTorregrosa/drush_language.

And will notify when it will be ready.

I am still working on that.

But that's interesting to note that in D8, languages does not have "status" anymore (and no more "languages" database table). But the module still has disable and enable methods. I think its has not been used/tested.

I will remove its.

Still working on this. I am currently testing.

As the default site language is in the simple config "system.site". I think the default language command also didn't work.

Manual tests ok for Drush 9.

For Drush 8: "No hook functions were found for language-default." => no one use the default language command.

Manual tests ok for me on Drush 9 and Drush 8.

Please see https://github.com/FlorentTorregrosa/drush_language for the changes.

It would be nice to preserve the different commits. Sorry I have not do that for @fgm works. But if you want I can prepare a branch with the detail of @fgm commits and mine applied on top of that.

Thanks for the review.

And hoping it will be merged before Drush 8 command will move again!!!

Bonjour Florent,

great that you have been working on this. And great you're providing a git multipatchfile, which makes this monster reviewable.
I did a first review, and everything looks thorough. Also i noticed you removed some weirdesses from different origins.
And obsoleted commands: good catch.

> For Drush 8: "No hook functions were found for language-default." => no one use the default language command.
Interesting find.

I'd say let's go all the way and add the console wrapper. So setting needswork.
* isAbsolutePath() is for free, just require webmozart/path-util in our composer.json (we must do this anyway to not rely on other project's implementation details) and change the condition slightly
* The batch should work too as console commands run in booted drupal. (or did you test?)

Guten Tag Axel :),

Thanks for your review!

• webmozart/path-util: Done (new patch and new commit on my Github repository). Good idea! Sometimes I forget the possibilites to use Composer. So simple. Now, that's one less blocker for the next point.
• Drupal console: I thought about it, but then (as in https://github.com/FlorentTorregrosa/drush_language/commit/1423cc442188a...) I thought that this project name is drush_language and not cli_language or something like that. Maybe it should be renamed.
  About the drush batch process, I don't currently now how to make it with Drupal console, so it needs work. I will ping the Drupal console team for a little help and opinion if they are interested with those commands.

Ping in the Drupal console community done: https://gitter.im/hechoendrupal/DrupalConsole?at=5a895380a2194eb80d7be4a6

I have just looked at the current Drupal console commands, and there is already a "locale:language:add" and the default language command can be done with a command to change the config and a cache clear. (For Drush, it can also be done that way)

So the only commands interesting for Drupal console would be the import and export of translations.

Hello,

@axel.rutz: no response from the Drupal console community in a week. Do you want to wait more?

Also increasing the priority because if other issues lands in Drush language it will make the work done here unusable or needing to adjust again.

I think we can merge the work done here now without closing the issue for Drupal console support if needed. To avoid patches on other issues to cancel the work done here or in the opposite way to prevent other people working on other issues.

I have just saw the other issues and people are also fixing what will be fixed here (#2873380: No hook functions were found for language-default, #2873379: No hook functions were found for language-enable).

Yeah, in fact you addressed 1), and i guess 2) should just work. And if not, we'll do a followup.

Committed, merged and release a RC1!

😍 THanks a lot! 😍

Thanks for the commits.

\o/

Deleting my mirror on Github as the commits have been merged and this issue is fixed.

@fgm: oups, already deleted my repository. I had put in the description that my repository was only there the time this issue is resolved. As I don't use regularly the "archive" feature of Github I didn't think about this option. Sorry, you are right, I could have broken websites... My bad.