module_list() and cache_clear_all() have changed in drupal 8 [#1605018]

Comment	File	Size	Author
#6	drush-1605018-6.patch	894 bytes	tim.plunkett
#4	drush-1605018-4.patch	890 bytes	tim.plunkett
#1	drush-1605018-1.patch	896 bytes	tim.plunkett

File	Size
drush-1605018-1.patch	896 bytes

Comment #2

tim.plunkett

he/him

English

Philadelphia

CreditAttribution: tim.plunkett commented 29 July 2012 at 22:34

Title:

Exception: cache_clear_all() no longer takes arguments, use cache() instead.

» module_list() and cache_clear_all() have changed

Log in or register to post comments

Comment #3

jonhattan

Spanish

Plasencia

CreditAttribution: jonhattan commented 30 July 2012 at 17:23

Title:

module_list() and cache_clear_all() have changed

» module_list() and cache_clear_all() have changed in drupal 8

Looking at cache() implementation I see

  // Temporary backwards compatibiltiy layer, allow old style prefixed cache
  // bin names to be passed as arguments.
  $bin = str_replace('cache_', '', $bin);

Should we call cache('update') instead of cache('cache_update') in this patch?

Log in or register to post comments

File	Size
drush-1605018-4.patch	890 bytes

Comment #5

jonhattan

Spanish

Plasencia

CreditAttribution: jonhattan commented 30 July 2012 at 19:48

Component:	Miscellaneous	» Base system (internal API)
Status:	Needs review	» Needs work

On a second look at drush, we need to replace calls to cache_clear_all() in more places.

Two options are: define cache_clear_all again for drupal 8 in commands/core/drupal/environment.inc or use a wrapper function for all versions. For example drupal_cache_clear_all() although there exist several X_cache_clear_all already in drush... doc on them should be improved also.

Log in or register to post comments

Comment #6

tim.plunkett

he/him

English

Philadelphia

CreditAttribution: tim.plunkett commented 7 January 2013 at 15:06

File	Size
drush-1605018-6.patch	894 bytes

I'm not really confident with doing #5 myself, but this is an update to #4 since core has changed some.

Log in or register to post comments

Comment #7

hansfn CreditAttribution: hansfn commented 3 April 2013 at 23:27

Version:

» 8.x-6.x-dev

OK, I also stumbled upon this problem when running "drush updatedb" in a D8 installation.

1) Shouldn't this have higher priority? Breaking the updatedb is rather critical ...
2) Looking at the patch, I'm wondering if it breaks on D7? Shouldn't the same version of Drush work on both D8 and D7?
3) Regarding the options in comment #5. I think "define cache_clear_all again for drupal 8 in commands/core/drupal/environment.inc" is the least messy, but I don't know the Drush code that well.

PS! I was forced to set a version - I hope I selected the right one.

Log in or register to post comments

Comment #8

tim.plunkett

he/him

English

Philadelphia

CreditAttribution: tim.plunkett commented 3 April 2013 at 23:31

1) D8 doesn't have an upgrade path, so you shouldn't be using updb anyway, until the alphas (or betas?) come out
2) Drush has versioned files. update.inc, update_6.inc, and update_7.inc
3) Yes, that's why this is "needs work"

The version number is correct, drush changed them around since I last commented.

Log in or register to post comments

Comment #9

greg.1.anderson CreditAttribution: greg.1.anderson commented 11 September 2013 at 05:12

Status:	Needs work	» Closed (won't fix)
Issue tags:		+Needs migration

This issue was marked closed (won't fix) because Drush has moved to Github.

If desired, you may copy this bug to our Github project and then post a link here to the new issue. Please also change the status of this issue to closed (duplicate).

Please ask support questions on Drupal Answers.