I've included several patches from drupalcode.org in the release https://www.drupal.org/node/2266543 which seem to fail validation although there is an existing whitelist entry.

Whitelist entry: ^http://cgit\.drupalcode\.org/.+\/patch/\?id=.+$
Failing URL: http://cgit.drupalcode.org/form_builder/patch/?id=e02d0af

Comments

torotil’s picture

torotil commented

I've released the distribution without those patches for now.

kreynen’s picture

kreynen commented
Related issues: +#1854474: drupalcode.org wildcard?

does it only fail on Drupal.org or does it fail verification when you run drush verify-makefile drupal-org.make locally?

torotil’s picture

torotil commented

It does also fail locally. Though I'm wondering why.

torotil’s picture

torotil commented

Ah, it seems that the whitelisting simply doesn't work for patches.

Running transformer DrushMakeDo_ProjectPatch on .make file for           [debug]
project form_builder [2.1 sec, 8.39 MB]
The patch 'http://cgit.drupalcode.org/form_builder/patch/?id=e02d0af'^[[31;40m^[[1m[error]^[[0m
is not hosted on drupal.org [2.1 sec, 8.39 MB]
The patch 'http://cgit.drupalcode.org/form_builder/patch/?id=7652d87'^[[31;40m^[[1m[error]^[[0m
is not hosted on drupal.org [2.1 sec, 8.4 MB]
The patch 'http://cgit.drupalcode.org/form_builder/patch/?id=d002536'^[[31;40m^[[1m[error]^[[0m
is not hosted on drupal.org [2.1 sec, 8.4 MB]
The patch                                                            ^[[31;40m^[[1m[error]^[[0m
'https://www.drupal.org/files/issues/2034543-form_builder-delete-cache-when-rendering-form_builder_interface-10.patch'
is not hosted on drupal.org [2.1 sec, 8.4 MB]
The patch                                                            ^[[31;40m^[[1m[error]^[[0m
'https://www.drupal.org/files/issues/form_builder-2278247-addField-fix-placeholder-handling-4.patch'
is not hosted on drupal.org [2.1 sec, 8.4 MB]

drush make doesn't even try to match those URLs against the regexps.

mrharolda’s picture

mrharolda commented

I got one failing patch too, which I "solved" by uploading the patch in the issue queue ...

projects[linkit][patch][] = "http://cgit.drupalcode.org/linkit/patch/?id=abf895c8e9d7efa6b34d6961113b8c539a2808bc"

mkhamash’s picture

mkhamash commented
Issue summary: View changes

I have also experienced this issue recently, with drupal.org packaging script.

Error message: The patch [error] {Patch URL} is not hosted on drupal.org
Patch URL: http://cgit.drupalcode.org/views/patch/?id=e5c8b65610fbfb93215466c2f234e...
make file: http://cgit.drupalcode.org/varbase/tree/drupal-org.make?id=ca56c0d793f4a...

gisle’s picture

gisle
he/him
Primary language Norwegian Bokmål
Location Norway
commented
Component: Code » Miscellaneous
Status: Active » Postponed (maintainer needs more info)

This is four years old.
In this still a problem?
It will be closed as outdated if there is no response in two weeks.

If it is a problem, it is probably not something the LWG will be able to resolve.
The right place may be: https://www.drupal.org/project/drupalorg_drush .

gisle’s picture

gisle
he/him
Primary language Norwegian Bokmål
Location Norway
commented
Status: Postponed (maintainer needs more info) » Closed (outdated)