Here's the very simplest .make file I could get to work with vanilla Drush Make:

api = 2
core = 7.x
projects[drupal][version] = 7.12

I'm able to successfully drush make distro.make foo and it pulls a copy of Drupal 7.12 into a directory called foo.

However, when I run drush verify-makefile distro.make, I get the following:

Could not locate drupal version 7.x-7.12, downloading latest stable version                                                              [warning]

That's no good. That basically forces me to keep two copies of my make file. :(

CommentFileSizeAuthor
#3 1432396-fix-core-release-version.patch648 byteshunmonk
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

webchick’s picture

Also due to this bug, I can't seem to require a -dev version of core.

dww’s picture

I *believe* this is yet another symptom of #1432476: drupalorg_drush always try to download release history XML info but I could be wrong.

hunmonk’s picture

Assigned: Unassigned » hunmonk
Status: Active » Needs review
FileSize
648 bytes

in the old days, we used to prevent the core drupal project from being included in drupal-org.make files. nowadays we'll want to allow it for easier profile development (we can handle the special case of a bootstrap.make file during packaging in the packaging script).

so, here's two line patch that fixes the problem with core version strings. tested, and both core and contrib projects work with this patch.

jhedstrom’s picture

Looks good to me. All tests are still passing, and this logic is very close to what drush make is doing internally for this.

dww’s picture

Status: Needs review » Needs work

The .make file in the original post still fails for me (now silently) with this patch applied. No core is built.

dww’s picture

Status: Needs work » Reviewed & tested by the community

Oh, I see. I was trying this:

drush make --drupal-org core.make core

But hunmonk pointed out that --drupal-org automatically sets --no-core. So, we're not building core in this case at all. Which is what we expect. And yeah, the strange error about 7.x-7.12 is gone from both make --drupal-org and verify-makefile.

So yeah, this can go in as an improvement.

hunmonk’s picture

Status: Reviewed & tested by the community » Needs work

probably would be a good idea to add a verify-makefile test for this first.

hunmonk’s picture

Status: Needs work » Fixed

added a test, ran all tests as passing, committed.

Automatically closed -- issue fixed for 2 weeks with no activity.