drush verify-makefile properly reports an error when drupal core is set to a development version (eg 6.x), but it does does not catch when drupal core is set to a non-existent release (eg. 6.99).

Comments

helmo’s picture

Project: Drush Make » Drush
Version: 6.x-3.x-dev »
Component: Code » Make
Priority: Normal » Minor

[ Powered by #1115636: Issue Macros and Templates - Drush Make]

Drush make is being merged into drush core (discussed in issue:#1310130: Put drush make in drush core)
This means that the issue queue is also moving. The drush queue has a component 'Make' especially for drush_make.

More information will be posted on the drush_make and drush project pages.

NOTE: the verification mostly checks syntax and does currently not connect to remote sources.

jhedstrom’s picture

Project: Drush » Drupal.org drush
Component: Make » Code

This command has been moved to the Drupal.org drush project.

dww’s picture

The only way to verify this is to actually try downloading core, or at least the release history. Currently, verify-makefile doesn't do anything like that, and is *just* parsing the .make file looking for things that are invalid. I'm not sure it's a good idea to fix this at all. I think there are a whole class of errors that can't be detected just by parsing the .make file (e.g. patches that fail to apply, etc) that we can only catch when actually building the .make file. IMHO, verify-makefile should just ensure the makefile is *valid* not that it actually works. If we go down this route, verify-makefile is going to bloat into something much more complex, and will take much longer to run. Therefore, I'm inclined to 'won't fix' this.

Other thoughts?

Thanks,
-Derek

dww’s picture

Status: Active » Closed (won't fix)

Yeah, based on an IRC chat with beerabd, we agree this is "won't fix".