api.drupal.org needs breadcrumbs

At this point, this is a version 7 fix, and I think we need the breadcrumbs for sure if we're planning to get all of contrib on api.d.o (and we just need them anyway).

Here's the code that is turning off the breadcrumbs, in drupalorg_crosssite_preprocess_page():

  $main_site = (variable_get('drupalorg_site', 'main') === 'main');

  // In most cases, the navigation elements should provide orientation within
  // the site. Breadcrumbs are usually not necessary.
  if (arg(0) !== 'admin') {
    $vars['breadcrumb'] = '';
  }

So I guess this would instead need to check the 'drupalorg_site' variable to see if it is on the API site, and if so, not turn off breadcrumbs after all.

There is an API site clone currently at
http://docs-api.redesign.devdrupal.org/api/drupal
that was set up for another purpose, but could be used. The API section of the site has not been tampered with.

The patch looks OK although the code comment should perhaps be updated, and it seems like we don't need two calls to variable_get('drupalorg_site', 'main') [there is one just above this code]. Should we refactor slightly?

But I am in 100% agreement that we need to turn the breadcrumbs on, and this does work [not surprising since I filed the issue. :) ].

Works for me! Except the word "excpet" is misspelled in the comment. :)

Thanks! I think we should commit the patch in #11 and push it out to api.drupal.org.

I have confirmed that it is working fine on the dev site. Example pages with breadcrumbs:
http://docs-api.redesign.devdrupal.org/api/drupal/includes!bootstrap.inc...
http://docs-api.redesign.devdrupal.org/api/drupal/core!lib!Drupal!Core!D...

I think the breadcrumbs are useful and we should have them enabled.

The only other possible thing to do would be to test it on a d.o clone and verify it doesn't turn on breadcrumbs or cause any other trouble. The patch looks completely safe in that regard though -- it was done carefully -- and I do not know which d.o clone to test on -- wouldn't want to screw someone's site up with some unknown code coming in.

I just tested this patch on one of the d.o dev sites. I verified that all the behavior that the $main_site variable is using is still working with this patch installed.

So we should be OK.

YEAH!!! Thanks!

This will become more and more essential as we add more projects to api.d.o (if we ever do go that route).

Not a bad idea. Would need to go into bluecheese.