Problem/Motivation

The summary of organisational contribution credits appears to be based on the first page of the pager, hence it misses the majority of credits.

https://www.drupal.org/third-and-grove#org-page-issue-credit This shows '1080' issue credits, but the summary below is suspiciously low, and corresponds to the first page of https://www.drupal.org/node/2373279/issue-credits

I tried to check the page for Third and Grove's Drupal core credit page but that's currently a 500, OOM maybe?

https://www.drupal.org/node/2373279/issue-credits/3060

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork drupalorg-3545749

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

catch created an issue. See original summary.

drumm’s picture

Re 500 errors - right now the issue credit listings are especially fragile, since the D7 site makes HTTP requests to the new site as part of its own page rendering. We have lowered the timeout when making the Guzzle requests in D7, so that should limit the 500 errors, but if we missed something, or we’re making 4 requests that use most of their allowed 10s, that will 500. The setup is indeed fragile. Rather than sinking time into making this work better, we should get the Views moved: #3545771: Move issue credit listings to new.drupal.org

drumm’s picture

Status: Active » Postponed (maintainer needs more info)

https://www.drupal.org/node/2373279/issue-credits is paged, showing the first 50 issues, with 21 more pages. So everything is consistent as far as I can tell. This is all counting just the last 12 months, which is what currently matters for rankings and program eligibility.

Is there something I might be missing or an approximate number you expect to see?

catch’s picture

Status: Postponed (maintainer needs more info) » Active

The screenshot attached to the issue summary is for https://www.drupal.org/third-and-grove#org-page-issue-credit, it shows 9 Drupal core core issue credits for the last year. The correct number is somewhere between 500 and 1,000, I don't know because the summary is broken, hence this issue...

When you click through to https://www.drupal.org/node/2373279/issue-credits the last five issues on that page are Drupal core, which matches the 5 issues shown on the summary. This suggests that the summary is generated only from the first page of the pager.

e.g. page 8 of that view shows Drupal core credits from April https://www.drupal.org/node/2373279/issue-credits?page=8

I would expect the high level credit summary to list all credits for each project listed (and probably every project too), pretty sure this is how it used to work prior to the new credit system.

fjgarlin’s picture

This suggests that the summary is generated only from the first page of the pager.

That is correct. What's shown in that summary is the first page aggregated data, and the first page only includes 5 Drupal core credits.

We cannot get a full count per project without requesting all pages via http requests. The data is correct, it's just the way it's being rendered.

Maybe we can move from:

Documentation, 2 issues
Drupal core, 5 issues

To

Documentation, 2+ issues
Drupal core, 5+ issues

or

Documentation issues
Drupal core issues

or

Documentation: fixed issues
Drupal core: fixed issues

This would be a quick formatting change, where we remove the innacurate number, and then we can focus the big efforts on #3545771: Move issue credit listings to new.drupal.org.

fjgarlin’s picture

Version: 1.0.x-dev » 7.x-3.x-dev

fjgarlin changed the visibility of the branch 3545749-organisation-credit-counts to hidden.

catch’s picture

Yeah removing the counts for now sounds fine - the total across all projects is listed on the organisation page anyway.

fjgarlin’s picture

  • drumm committed 3ef5ab6f on 7.x-3.x authored by fjgarlin
    [#3545749] fix: Remove undercounted credited issue counts from...
drumm’s picture

Status: Needs review » Fixed

I finally decided on a wording and this is deployed. With #3545771: Move issue credit listings to new.drupal.org split off into a separate issue, I think this is now fixed. Please reopen if I missed anything.

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.